Skip to content

Cap Resolution#7828

Closed
kphoenix137 wants to merge 1 commit intodiasurgical:masterfrom
kphoenix137:cap-resolution
Closed

Cap Resolution#7828
kphoenix137 wants to merge 1 commit intodiasurgical:masterfrom
kphoenix137:cap-resolution

Conversation

@kphoenix137
Copy link
Copy Markdown
Collaborator

Cap screen resolution so that width cannot exceed 1280 and height cannot exceed 720 in order to prevent players from utilizing resolution as a meta gameplay strategy.

@Trihedraf
Copy link
Copy Markdown
Collaborator

It should be 1280x800 for us 16:10 people. Steamdecks, MacBooks, a lot of newer gaming laptops.

@StephenCWills
Copy link
Copy Markdown
Member

FYI, 960p is a popular resolution because you can use the zoom flag to get back to the 480p viewport with a smaller UI.

@kphoenix137
Copy link
Copy Markdown
Collaborator Author

kphoenix137 commented Mar 10, 2025

It should be 1280x800 for us 16:10 people. Steamdecks, MacBooks, a lot of newer gaming laptops.

You'd be able to run 1152x720 to maintain 16:10. Increasing the vertical height cap to 800 would allow the 1280 horizontal cap to be exceeded on 16:9 to 1422x800 using Fit to Screen. That's the reason I put the horizontal cap as well, since without it, you could easily bypass the restrictions using a larger width and Fit to Screen.

FYI, 960p is a popular resolution because you can use the zoom flag to get back to the 480p viewport with a smaller UI.
I believe it would be better to have a scalable UI down the road than to set the cap based on that.

960p is a bit too much. (Although people using 4:3 monitors and Fit to Screen will be able to achieve 1280x960 using this PR)

image

I created this image awhile back to attempt to demonstrate "how much of the world" you're able to see at much between different Diablo games. At 720p, we are still exceeding what these other games allow the player to see, so 720p is generous.

@Trihedraf
Copy link
Copy Markdown
Collaborator

Nevermind fit to screen with 720p takes it up 800p

@kphoenix137
Copy link
Copy Markdown
Collaborator Author

Nevermind fit to screen with 720p takes it up 800p

Oh, I didn't think about it that way when explaining the Fit to Screen thing. Yeah that sounds right :D

@StephenCWills
Copy link
Copy Markdown
Member

960p is a bit too much...

I created this image awhile back to attempt to demonstrate "how much of the world" you're able to see at much between different Diablo games. At 720p, we are still exceeding what these other games allow the player to see, so 720p is generous.

Okay, but people who play at 960p with zoom flag are actually just playing 480p with more of the game world visible around the menus. So your graphic does not compel me to agree with you here.

480p:
image

960p:
image

@kphoenix137
Copy link
Copy Markdown
Collaborator Author

960p is a bit too much...
I created this image awhile back to attempt to demonstrate "how much of the world" you're able to see at much between different Diablo games. At 720p, we are still exceeding what these other games allow the player to see, so 720p is generous.

Okay, but people who play at 960p with zoom flag are actually just playing 480p with more of the game world visible around the menus. So your graphic does not compel me to agree with you here.

480p: image

960p: image

Then I would believe the superior option here would be to allow up to 2560x1440p, while forcing the zoom flag for resolutions above 720p.

@StephenCWills
Copy link
Copy Markdown
Member

I'd be fine with that.

@kphoenix137 kphoenix137 marked this pull request as draft March 10, 2025 04:21
@kphoenix137
Copy link
Copy Markdown
Collaborator Author

I'd be fine with that.

Perhaps we can add a 4x zoom option to conditionally allow the permazoomed players to still be able to zoom in the same way someone without permazoom can.

@StephenCWills
Copy link
Copy Markdown
Member

I think it's fine if we don't. 960p zoom players currently can't zoom in that far, and UI scaling independently is on the roadmap for the project.

@kphoenix137
Copy link
Copy Markdown
Collaborator Author

I'd be fine with that.

Actually, I've come to the conclusion that this exact change would prevent the need for capping resolution altogether.

480p - 720p: 1x zoom (no zoom)
721p-1440p: 2x zoom
1441p-2880p: 3x zoom

@StephenCWills
Copy link
Copy Markdown
Member

StephenCWills commented Mar 10, 2025

Right, but there are other reasons to cap the resolution.

image

image

@FitzRoyX
Copy link
Copy Markdown

FitzRoyX commented Mar 10, 2025

It should be 1280x800 for us 16:10 people. Steamdecks, MacBooks, a lot of newer gaming laptops.

You're actually raising an interesting point that wasn't brought up in the discord. There are plenty of laptops out there with tweener screen resolutions like 1366x768 and 1600x900. Forcing them into a blurry fullscreen experience just because it's slightly more than the 720p limit is a bit harsh.

Yeah, 4k does indeed make a lot of fixed sized designs of the past look silly. 4k is 4 times the pixels as 1080p. That kind of pixel density should probably be looking at doing some integer scaling. Whereas integer scaling on a 1080p display can come off as looking "chunky" and dated. Diablo isn't really a "pixel art" game either. It is 3d models converted to fixed size sprites, so it really can't pull of the big pixel look the way Super Mario Bros 3 can.

@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Mar 10, 2025

min almost exceeds that cap at lowest resolution: 1146x480, it would limit me to a max of 536p 💩

@kphoenix137
Copy link
Copy Markdown
Collaborator Author

min almost exceeds that cap at lowest resolution: 1146x480, it would limit me to a max of 536p 💩

I'm confused. You would only need to set a single dimension and then use fit to screen. It doesn't do a cap based on the screen dimensions after fit to screen expands the view area

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants