More consistent gamepad context sensitivity#7829
Merged
AJenbo merged 1 commit intodiasurgical:masterfrom Mar 16, 2025
Merged
Conversation
StephenCWills
force-pushed
the
gamepad-context-sensitivity
branch
from
388c99c to
49a016c
Compare
AJenbo
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the order of operations between
GetLeftStickOrDPadGameUIHandler(),PerformPrimaryAction(),PerformSecondaryAction(), andPerformSpellAction()so that menu interactions work more consistently when multiple menus are open. As an example, if you managed to get the inventory and the speedbook open at the same time, gamepad would interact with the inventory but the info panel would only show the spell from the speedbook you happened to be hovering over. As another example, if you managed to get the char panel and speedbook open at the same time with stat points to distribute, the d-pad and analog stick would prioritize the char panel whereas the primary action button would prioritize the speedbook.The PR also disables various padmapper actions when game menus are open. For example, you can no longer open and close the inventory while browsing a towner's store menus.