Natural Fire Wall light expansion#7838
Merged
AJenbo merged 1 commit intodiasurgical:masterfrom Mar 13, 2025
Merged
Conversation
Member
|
With how things are going we won't need hardware rendering by 1.7.0 |
AJenbo
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
y = 11 - |x - 11|to compute the index for the light radius of the Fire Wall, allowing us to both ramp it up when the Fire Wall is growing and also ramp it back down when the Fire Wall is shrinking.Normal speed:
DevilutionX-2025-03-12_20.33.36.mp4
Slow:
DevilutionX-2025-03-12_20.35.34.mp4
This resolves #7819 -- Although, technically that is an issue about two separate things. This is just what happens when you don't make two separate issues. 🤷