Don't darken flame wave after it reaches full brightness#7839
Merged
AJenbo merged 1 commit intodiasurgical:masterfrom Mar 13, 2025
Merged
Don't darken flame wave after it reaches full brightness#7839AJenbo merged 1 commit intodiasurgical:masterfrom
AJenbo merged 1 commit intodiasurgical:masterfrom
Conversation
AJenbo
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the light radius of Flame Wave missiles which was inexplicably hardcoded to 8 despite the missile having already reached a light radius of 12. I also removed the logic that uses
var3andvar4to limit the frequency at which Flame Wave lights update their position, since I don't think we need it anymore now that the light jitter was fixed.The following video, shared by @FitzRoyX on Discord, demonstrates how the wall gets darker in the middle of the spell despite the wall of flame continuously moving closer to the wall.
fw2slo.mp4