Check for MonsterMode::Death in isPossibleToHit()#7841
Merged
StephenCWills merged 1 commit intodiasurgical:masterfrom Mar 15, 2025
Merged
Check for MonsterMode::Death in isPossibleToHit()#7841StephenCWills merged 1 commit intodiasurgical:masterfrom
StephenCWills merged 1 commit intodiasurgical:masterfrom
Conversation
qndel
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently a team of four reported on Discord there was a Blood Knight in their game that was still alive after Diablo was eliminated.
DiabloDeath()only updates the monster's animation and mode, but not hitpoints. The game stops callingProcessPlayers(), butProcessMissiles()should still be active. So my theory is that if a stray missile happens to hit the Blood Knight while Diablo is bleeding out, it could engage hit recovery which would override the animation and mode of the monster.It seems reasonable to include
MonsterMode::Deathin theisPossibleToHit()function to prevent missiles from hitting monsters that were killed byDiabloDeath(). Monsters that were killed by other means should probably also not be possible to hit.