Compute frame offset count based on min data for re-encode#7853
Closed
StephenCWills wants to merge 1 commit intodiasurgical:masterfrom
Closed
Compute frame offset count based on min data for re-encode#7853StephenCWills wants to merge 1 commit intodiasurgical:masterfrom
StephenCWills wants to merge 1 commit intodiasurgical:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR computes the frame offset count to avoid the assumption that there are no unused frames.
This is a simpler alternative to #7852. The downside is that there will be gaps in the
pDungeonCelslookup table, soGetDunFrame(frame + 1) - GetDunFrame(frame)cannot be used reliably to compute the size of a CEL frame.