Fix dropped unique item synchronisation bug#7859
Closed
Yggdrasill wants to merge 1 commit intodiasurgical:masterfrom
Closed
Fix dropped unique item synchronisation bug#7859Yggdrasill wants to merge 1 commit intodiasurgical:masterfrom
Yggdrasill wants to merge 1 commit intodiasurgical:masterfrom
Conversation
This commit addresses a bug in which RecreateItem() is called from inv.cpp:SyncItemDrop(), and it tries to extract uidOffset from an uninitialised item.dwBuff. Besides being an obvious bug, this also caused temporary morphing for the receiving client.
Contributor
Author
|
Sorry about that, I forgot to attach the file. Here's the character file: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is just a small fix-up of network synchronisation code and a use of an uninitialised variable, which is most likely only noticeable now due to the new unique item generation code introduced in #7060.
Basically, on the receiving system, dropped items temporarily morph until the save is reloaded. The reason is that RecreateItem() tries to extract uidOffset from item.dwBuff. Since item.dwBuff was never initialised in SyncDropItem() before the call to RecreateItem(), a Xorine's Ring would morph into a Ring of Thunder temporarily on my system.
The fix is simple, and simply moves initialisation of item.dwBuff to before the call. I have attached a character file with Bramble and Xorine's Ring in the inventory for you to test.
Thanks,
Yggdrasill