Skip to content

Expand Lua Implementation#7861

Closed
kphoenix137 wants to merge 14 commits intodiasurgical:masterfrom
kphoenix137:expand-lua
Closed

Expand Lua Implementation#7861
kphoenix137 wants to merge 14 commits intodiasurgical:masterfrom
kphoenix137:expand-lua

Conversation

@kphoenix137
Copy link
Copy Markdown
Collaborator

@kphoenix137 kphoenix137 commented Mar 18, 2025 •
edited
Loading

  • Makes events available globally
  • Adds dynamic mod loading from the mods folder
  • Adds hooks in Item Generation that allow configuring how items are skipped when generating items both leveraging the existing vendor item skipping and adding dungeon item skipping

@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Mar 19, 2025

Adds dynamic mod loading from the mods folder
<3

glebm
glebm reviewed Mar 20, 2025
View reviewed changes
Comment thread Source/lua/events/items.cpp
glebm
glebm reviewed Mar 20, 2025
View reviewed changes
Comment thread Source/options.cpp Outdated
glebm
glebm reviewed Mar 20, 2025
View reviewed changes
Comment thread Source/lua/events/items.cpp Outdated
glebm
glebm reviewed Mar 20, 2025
View reviewed changes
Comment thread Source/utils/file_util.h Outdated
glebm
glebm reviewed Mar 20, 2025
View reviewed changes
Comment thread Source/lua/usertypes/items.cpp Outdated
"dwBuff", &Item::dwBuff);
}

sol::object CreateItemObject(const Item &item)
Copy link
Copy Markdown
Collaborator

@glebm glebm Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed. Now that item is registered as a usertype, you can pass items directly into Lua functions.

glebm
glebm reviewed Mar 20, 2025
View reviewed changes
Comment thread Source/lua/usertypes/items.cpp Outdated
glebm
glebm reviewed Mar 20, 2025
View reviewed changes
Comment thread Source/lua/usertypes/items.cpp Outdated
@kphoenix137 kphoenix137 changed the title Expand Lua Implementation (Dynamic Mod Loading, Item Hooks) Expand Lua Implementation Mar 20, 2025
@kphoenix137 kphoenix137 closed this Apr 1, 2025
@kphoenix137
Copy link
Copy Markdown
Collaborator Author

kphoenix137 commented Apr 1, 2025

PR had it's elements extracted into new PRs. This is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glebm glebm glebm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kphoenix137 @AJenbo @glebm