Skip to content

SDL3: Some more migration#8209

Merged
glebm merged 3 commits intodiasurgical:masterfrom
glebm:more-sdl3
Oct 9, 2025
Merged

SDL3: Some more migration#8209
glebm merged 3 commits intodiasurgical:masterfrom
glebm:more-sdl3

Conversation

@glebm
Copy link
Copy Markdown
Collaborator

@glebm glebm commented Oct 5, 2025

No description provided.

@glebm glebm enabled auto-merge (rebase) October 5, 2025 20:51
@glebm glebm force-pushed the more-sdl3 branch 3 times, most recently from 6f58e04 to ddd77ec Compare October 6, 2025 00:00
Comment thread Source/controls/input.h Outdated
@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Oct 6, 2025

I like the ByteSwap changes

@glebm glebm force-pushed the more-sdl3 branch 2 times, most recently from 616c80d to 7cfc800 Compare October 6, 2025 09:36
Comment thread Source/controls/remap_keyboard.h Outdated
Comment thread Source/utils/sdl_mutex.h
Comment thread Source/utils/sdl_compat.h Outdated
Comment thread Source/utils/display.cpp Outdated
Comment thread Source/utils/display.cpp Outdated
Comment thread Source/utils/display.cpp Outdated
Comment thread Source/utils/display.cpp
AJenbo
AJenbo previously requested changes Oct 8, 2025
Copy link
Copy Markdown
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review done

@glebm glebm force-pushed the more-sdl3 branch 5 times, most recently from 32a4374 to 07d38cc Compare October 8, 2025 22:58
Comment thread Source/init.cpp
@glebm glebm force-pushed the more-sdl3 branch 3 times, most recently from e0c87a7 to 0c2c46d Compare October 8, 2025 23:35
@glebm glebm force-pushed the more-sdl3 branch 3 times, most recently from 729500d to e65c989 Compare October 9, 2025 00:10
@glebm
Copy link
Copy Markdown
Collaborator Author

glebm commented Oct 9, 2025

Once this is merged, I'll introduce some helpers / backports in a follow-up PR based on the patterns that I've noticed when migrating so far

@AJenbo AJenbo dismissed their stale review October 9, 2025 00:13

fixed

@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Oct 9, 2025

From my experience SDL3 is a really nice clean up and they also did a good job with bringing over many targets. If we abstract the old one well this could be a nice clean up in the end.

@glebm glebm merged commit 1bbe8bf into diasurgical:master Oct 9, 2025
26 checks passed
@glebm glebm deleted the more-sdl3 branch October 9, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants