Skip to content

Fix Firewall/Flamewave/Lightningwall not working on every tile#8251

Merged
AJenbo merged 4 commits intodiasurgical:masterfrom
obligaron:firewall
Nov 2, 2025
Merged

Fix Firewall/Flamewave/Lightningwall not working on every tile#8251
AJenbo merged 4 commits intodiasurgical:masterfrom
obligaron:firewall

Conversation

@obligaron
Copy link
Copy Markdown
Contributor

Fixes #6189
Fixes #6190

Notes

  • When casting Firewall, Lightningwall, or Flamewave in the north, south, west, or east direction, an extra segment is added.
  • For Firewall and Lightningwall, the extra segment only damages walking players and monsters.
  • The extra segment is currently invisible but could be rendered. This is not part of this PR because it changes the visuals, and there are some graphic glitches (see the last example videos).
  • The first commit harmonizes the growth logic between Firewall and Flamewave (no behavior changes).
  • The second commit adjusts the methods called in CheckMissileCol to get references instead of indexes (no behavior changes).
  • The third commit adds gaps as necessary.
  • The fourth commit ensures that the newly added gaps in the firewall and LightningWall only damage walking monsters and players.

Example Videos

Firewall

Master

Master_Firewall.mp4

PR

PR_Firewall.mp4

Flamewave

Master

Master_Flamewave.mp4

PR

PR_Flamewave.mp4

Lightningwall

Master

Master_Lightningwall.mp4

PR

PR_Lightningwall.mp4

With rendered gaps

Firewall / Flamewave

PR_WithVisibleGap.mp4

Lightningwall

PR_WithVisibleGapLightning.mp4

@AJenbo AJenbo merged commit 187bdba into diasurgical:master Nov 2, 2025
25 of 26 checks passed
@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Nov 2, 2025

Nice to have a solution for this :)

@obligaron obligaron deleted the firewall branch November 2, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firewall/lightning wall not dealing damage at every other tile Flamewave not damaging every other tile

2 participants