Fix double-click handling in UI lists and improve test suite for missing MPQ assets#8273
Closed
skypher wants to merge 3 commits intodiasurgical:masterfrom
Closed
Fix double-click handling in UI lists and improve test suite for missing MPQ assets#8273skypher wants to merge 3 commits intodiasurgical:masterfrom
skypher wants to merge 3 commits intodiasurgical:masterfrom
Conversation
Modified test suite to handle missing MPQ assets (spawn.mpq/DIABDAT.MPQ)
gracefully instead of failing. Tests now:
- Run even when MPQ assets are not present
- Skip tests requiring MPQ assets with GTEST_SKIP()
- Display a clear summary at the end explaining why tests were skipped
- Show total count and reasons for skipped tests
Changes:
- test/main.cpp: Added custom GoogleTest listener to track and report skip reasons
- test/{inv,pack,player,timedemo,vendor,writehero}_test.cpp:
Replaced ASSERT_TRUE(HaveMainData()) with GTEST_SKIP() for graceful skipping
This allows the test suite to run in CI/CD environments without MPQ assets
while still providing clear feedback about which tests couldn't run and why.
Contributor
Author
|
Wrong target repository - recreating PR on skypher/DevilutionX |
Member
|
if this is just to keep your fork in sync there should be a button to do so on github, or you can simply reset your local master to the upstream master and push to your fork. Doing it by merging PRs on github will create additional commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two sets of improvements:
1. Fix double-click handling in UI lists
2. Gracefully handle missing MPQ assets in test suite
Modified the test suite to handle missing MPQ assets (spawn.mpq/DIABDAT.MPQ) gracefully instead of failing hard.
Changes:
GTEST_SKIP()Benefits:
Example output when MPQ is missing:
Test plan