Modernize Windows build workflow and improve dependency resilience #8461
+83
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grated to CMakePresets.
StephenCWills
requested changes
Feb 8, 2026
Comment on lines
298
to
303
|
|
||
| * **Through GCC/WSL in Visual Studio** | ||
|
|
||
| 1. Ensure the WSL environment has the build pre-requisites for both devilutionX (see "Installing Dependencies on Debian and Ubuntu" under the "Linux" section above) and [WSL remote development](https://docs.microsoft.com/en-us/cpp/linux/connect-to-your-remote-linux-computer?view=msvc-160#connect-to-wsl). | ||
| 2. Select the `WSL-GCC-x64-Debug` configuration. | ||
| 3. Select `Build devilution` from the `Build` menu. |
Member
There was a problem hiding this comment.
This section should be removed because the configuration was dropped in the migration from CMakeSettings.json to CMakePresets.json.
Suggested change
Member
|
I understand the issue with |
Collaborator
Author
|
|
Member
|
Seems like vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO fmtlib/fmt
REF "${VERSION}"
SHA512 f0da82c545b01692e9fd30fdfb613dbb8dd9716983dcd0ff19ac2a8d36f74beb5540ef38072fdecc1e34191b3682a8542ecbf3a61ef287dbba0a2679d4e023f2
HEAD_REF master
)Actually, vcpkg_download_distfile(ARCHIVE
URLS "https://sourceware.org/pub/bzip2/bzip2-${VERSION}.tar.gz"
"https://www.mirrorservice.org/sites/sourceware.org/pub/bzip2/bzip2-${VERSION}.tar.gz"
FILENAME "bzip2-${VERSION}.tar.gz"
SHA512 083f5e675d73f3233c7930ebe20425a533feedeaaa9d8cc86831312a6581cefbe6ed0d08d2fa89be81082f2a5abdabca8b3c080bf97218a1bd59dc118a30b9f3
) |
AJenbo
reviewed
Feb 8, 2026
| ### Compiling | ||
|
|
||
| * **Through Open->CMake in Visual Studio** | ||
| * **Through CMake Presets in Visual Studio (Recommended)** |
Member
There was a problem hiding this comment.
Why is it recommended? It's not how we do releases, it's mostly just for people that insist on using VS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated build configurations from the legacy CMakeSettings.json to the modern CMakePresets.json standard. This improves compatibility across IDEs (Visual Studio, VS Code, CLion) and command-line workflows.
Changes
How to use
In Visual Studio, simply open the project folder. The IDE will automatically detect the presets. Select your desired configuration from the dropdown (e.g., x64 Debug) and build.