[feature] Add Lua mod infrastructure (OnMonsterDeath, OnItemUse hooks)#8478
Draft
yuripourre wants to merge 1 commit intodiasurgical:masterfrom
Draft
[feature] Add Lua mod infrastructure (OnMonsterDeath, OnItemUse hooks)#8478yuripourre wants to merge 1 commit intodiasurgical:masterfrom
yuripourre wants to merge 1 commit intodiasurgical:masterfrom
Conversation
14bda20 to
5bc29cd
Compare
5bc29cd to
a923df7
Compare
Trihedraf
approved these changes
Feb 20, 2026
Collaborator
|
This looks good and a big chunk of really useful hooks 👍 |
Collaborator
Author
Yeah, I am eager to revive the soulstone mod! Dreaming with an "Act 2" mod. 🤩 |
Collaborator
Author
|
@Trihedraf thanks for reviewing! |
Collaborator
Author
|
This PR can be simiplified, I will refactor this and re-activate when done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides the C++ bindings and Lua events needed to implement the soulstone mod
New events (assets/lua/devilutionx/events.lua):
New devilutionx.game module:
Extended devilutionx.monsters:
Extended devilutionx.player:
Extended devilutionx.items:
C++ hooks (no-ops when no Lua mod is registered):