Make portal positions dynamic (pre-work for multitown)#8554
Open
yuripourre wants to merge 1 commit intodiasurgical:masterfrom
Open
Make portal positions dynamic (pre-work for multitown)#8554yuripourre wants to merge 1 commit intodiasurgical:masterfrom
yuripourre wants to merge 1 commit intodiasurgical:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR turns the
Point PortalTownPosition[MAXPORTAL]array into a dynamic arraystd::array<Point, MAXPORTAL> ActivePortalPositions.The main change is to access the portals' positions using
GetPortalTownPosition(i)instead ofPortalTownPosition[i].The reason for that is to make easier to modify this structure and change the positions of town portals in other towns.