synthesis(experiment A): agentsview+periscope — merge purified+PR26 onto merged - #29
Merged
Merged
Conversation
DuckDB config resolution currently leaves a leading `~` literal in
`[duckdb].path`, so daemon-backed pushes can canonicalize the server
mirror path against the daemon working directory instead of the user's
home directory.
This expands leading-home shorthand during DuckDB config resolution,
alongside the existing defaulting and env expansion, so the daemon and
in-process callers resolve the same mirror path from the same config
value. `${HOME}` expansion, default-path fallback, and non-leading
tildes keep their current behavior. The change stays in
`internal/config` with focused resolution regression coverage.
The config snippet and daemon-vs-in-process repro came from @halms's
issue report.
Closes kenn-io#1264
---------
Co-authored-by: Marius van Niekerk <marius.v.niekerk@gmail.com>
Second PR in the artifact-sync split (follows kenn-io#1242, which froze the wire format and added the docbank-backed store). Extracted from the closed kenn-io#1239 branch with review fixes applied during extraction. - **SQLite publication ledger** (`internal/db`): `artifact_export_queue`, `artifact_publications`, `artifact_publication_revisions`, `artifact_checkpoint_heads`/`_floors`, plus session triggers that enqueue owned-session changes. Triggers are origin-gated — they fire only once an artifact origin exists in `pg_sync_state` — so archives that never opt in carry no queue writes. Trigger DDL lives in Go and is installed after column migrations (drops run before), so no trigger references session columns while migrations run. - **Go enqueue hooks** for child-only mutations that don't touch trigger-covered session columns: batch message writes (queue generation sampled around the batch, enqueues exactly once when the triggers didn't fire), standalone usage-event replacement, and token-coverage backfill. Queue bootstrap is an explicit call at origin creation, not a migrate-time backfill. - **Origin lifecycle** (`internal/artifact`): `EnsureOrigin`/`AdoptOrigin`/`StoredOrigin`. Creating or adopting an origin bootstraps the export queue; a failed bootstrap rolls the origin back (deleting the key when there was none before, since the gates test key existence) so a retry re-runs population. Adopting over a different established origin force-requeues every owned session with a generation bump, because prior acknowledgements belong to the old origin. - **Checkpointed export pipeline** (`internal/artifact`): claims pending queue rows, publishes content-addressed session manifests and segments into the store, records publication revisions, and advances per-origin checkpoint heads with monotone sequence reservation. Stale claims (a writer advanced the generation mid-export) roll back atomically. Incremental export is bounded by the dirty batch; an unchanged archive costs a catalog identity check only. Full export streams all bodies, then re-checks the queue up to 32 settle rounds — hitting the bound returns the accumulated result with an error meaning "made progress, run again." - **Resync carriage**: `CopySyncStateFrom` carries queue, publication, revision, and checkpoint state across a full resync and re-dirties every copied queue row — the origin gate keeps triggers silent in the rebuild's temp DB, and a parser bump changes manifest hashes anyway, so the exporter must re-verify each session (unchanged content is cheap to skip, being content-addressed). - Export-side only. Nothing wires the pipeline to the daemon or CLI yet; that lands with folder transport and import in a later PR. There is no import/read path here. - The ledger is local SQLite state. PostgreSQL push and shared query shapes are untouched. - The wire format is unchanged: no golden churn, format stays frozen at v1. - `internal/db/artifact_publication.go` — queue and ledger SQL, origin-gated enqueue - `internal/db/db.go` — trigger DDL split around column migrations, bootstrap/requeue - `internal/artifact/export.go` — publish → manifest → checkpoint ordering and claim lifecycle - `internal/artifact/origin.go` — origin lifecycle and rollback semantics - `internal/db/orphaned.go` — resync carriage and the pending-flag decision Co-authored-by: Wes McKinney <wesm@users.noreply.github.com>
Supersedes kenn-io#1167 — same feature, rebuilt as a lean series on the capability work that landed in kenn-io#1282/kenn-io#1283. The comment on kenn-io#1167 records what was cut and why. ## What this does Adds Omnigent to the supported agents. Omnigent stores every conversation in one SQLite file (`chat.db`), so this follows the same container model as Zed: sync watches one file, and the archive holds one session per conversation (`omnigent:0:<hex>`). - Scheduled syncs reparse the container when its fingerprint (mtime + hash of the db and WAL) changes. - Watcher events do a bounded, indexed scan of only the members whose `updated_at` moved, and retire disappeared members as tombstones. WAL `-shm` checkpoint noise is ignored. - Deleting a conversation (or the whole db) tombstones its sessions; nothing is destroyed. ## Notes - Supports the two schema generations that ship in released Omnigent builds, including the current binary-uuid one. The oldest shape is reported as unsupported without failing sync; the interim `session_overrides` shape is not supported. - `chat.db` co-locates transcripts with authentication secrets, so Omnigent is excluded from remote sync (capability from kenn-io#1282, nested-root enforcement from kenn-io#1283). - Validated against a chat.db produced by Omnigent's own store code at upstream head, not just fixtures (evidence in `docs/internal/session-format-sources.md`). - Known trade-offs (Zed parity): the scheduled reparse scales with container size, and edits that don't bump `updated_at` wait for the scheduled pass instead of the watcher. ## Where to look - `internal/parser/omnigent.go` — schema detection and member queries - `internal/parser/omnigent_provider.go` — discovery, fingerprinting, watcher scan, tombstones - `internal/sync/engine.go` — container scheduling and the persistent-archive audit fallback - `internal/sync/omnigent_integration_test.go` — end-to-end sync coverage Co-authored-by: Wes McKinney <wesm@users.noreply.github.com>
Restore litellm_snapshot.json.gz from upstream AgentsView artifact branch (kenn-io/agentsview litellm-pricing-snapshot) and track it in-repo so go:embed in internal/pricing/fallback.go works without a pre-build restore. Upstream keeps the snapshot gitignored and restores via make pricing-snapshot; Periscope purified line vendors the same bytes for cloud/CI bare go test.
- Point ci-pr.yml at the fork workflow so periscope paths apply on PR CI - Finish periscope rename in build_script_test, desktop-dev.ps1, and .air.toml - Hydrate docs assets from kenn-io/agentsview when origin lacks orphan branches - Exclude cherry-picked context visualizer from kit-ui-check; fix SessionBreadcrumb shadow token
- Re-enable full kit-ui-check over src (remove context exclusion script) - Wrap context panels in Card; use EmptyState for loading/error/unknown states - Normalize spacing gaps to var(--space-N) tokens across context components - Rename summary header classes to avoid hand-rolled-top-bar false positives
…ration Prior CI fix commits only updated commit messages while the actual file changes stayed in the working tree. PR CI kept calling upstream kenn-io/agentsview workflows, so periscope path fixes never ran. - Point ci-pr.yml at the checked-in workflow instead of upstream main - Fetch docs asset branches from kenn-io/agentsview when origin lacks them - Migrate context visualizer components to kit-ui primitives (0 findings) - Align dev script paths (.air.toml, desktop-dev.ps1, build_script_test.go)
…ged) The prior commit used commit-clean without staging, so it duplicated HEAD with no file changes. This commit actually lands: - ci-pr.yml -> local ./.github/workflows/ci.yml (not upstream @main) - hydrate-assets.sh upstream fallback to kenn-io/agentsview asset branches - context visualizer kit-ui Card/EmptyState/spacing migration (0 findings) - periscope dev path alignment (.air.toml, desktop-dev.ps1, build_script_test)
Mandatory git add → verify-staged-for-commit → commit-clean sequence. Blocks message-only commits when edits stay unstaged (periscope PR #26 root cause).
Replace machine-local /Users/ann/dev/periscope/docs path with v1-ui-spec.md so docs build and link checks pass in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
context-session-visualizer-spec.md was renamed to periscope-spec.md in bc0c13a; update visualizer planning docs so docs CI link checks pass. Co-authored-by: Cursor <cursoragent@cursor.com>
Exercise copied scripts under temp repo, bootstrap via commit-clean, fix bare-repo detection in sync-attribution, and empty verify_args under set -u. Co-authored-by: Cursor <cursoragent@cursor.com>
…b-f559 feat: upstream PR #23 stack onto purified (kenn-io#1274 DuckDB + kenn-io#1251 artifact + kenn-io#1284 Omnigent)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Two-parent merge retains all original SHAs from both lines: - parent1: origin/merged (Periscope fork Layer 2+3) - parent2: origin/cursor/agentsview-purified-onto-kenn-f559 (kenn-io replay + PR #26) Tree resolution (oramasys-method / ARCHITECTURE.md matryoshka): - Base tree: purified (upstream modernization + kenn-io#1274/kenn-io#1251/kenn-io#1284) - Overlay from merged: internal/summarize, internal/llm, context UI, install/release/sync scripts, jetbrains-plugin, ECC bundles, branding docs No synthetic upstream replay commits. Conflict resolution favors implementation plan layers; single merge commit minimizes artificial history. Synthetic pass commits preserved on cursor/agentsview-plus-periscope-synthetic-pass-f559.
cursor
Bot
force-pushed
the
cursor/agentsview-plus-periscope-f559
branch
from
July 29, 2026 07:35
d42bd53 to
732720c
Compare
|
Analysis CompleteGenerated ECC bundle from 27 commits | Confidence: 85% View Pull Request #30Repository Profile
Changed Files (300)
Top hotspots
Top directories
Analysis Depth Readiness (deep-ready, 100%)ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.
Reference Set Readiness (3/7, 43%)
Likely Future Issues (7)
Suggested Follow-up Work (7)
Copy-ready bodies chore: sync config templates for .github/ISSUE_TEMPLATE/config.yml + .impeccable/live/config.json ## Summary
- Update the example env files, sample configs, or deployment templates that should mirror the changed runtime configuration surface.
## Why
- Backfill example env files or config templates before a fresh setup drifts from the shipped runtime surface.
## Touched paths
- `.github/ISSUE_TEMPLATE/config.yml`
- `.impeccable/live/config.json`
## Validation
- Update the repo example env file or config template that should reflect the new runtime settings.
- Run the setup, boot, or deployment validation flow that depends on the changed config surface.test: add auth coverage for cmd/periscope/session.go ## Summary
- Add auth, session, or permission regression coverage for the recently changed security-sensitive surface.
## Why
- Backfill auth or permission regression coverage before another access-control change lands on the touched surface.
## Touched paths
- `cmd/periscope/session.go`
## Validation
- Add or extend integration / e2e coverage for the changed auth, session, middleware, or permission surface.
- Exercise allowed and denied flows, invalid or expired credentials, or equivalent access-control boundary cases.test: add CLI coverage for cmd/periscope/cli.go ## Summary
- Add shell, CLI, or end-to-end coverage for the recently changed command surface.
## Why
- Backfill CLI coverage before another command-surface change lands on the touched paths.
## Touched paths
- `cmd/periscope/cli.go`
## Validation
- Add or extend shell, CLI, or end-to-end coverage for the changed command surface.
- Exercise the user-facing command invocation and expected exit/output behavior.analysis: add reference-set evidence for .agents/skills/localization-paraglide/SKILL.md + .agents/skills/localization-paraglide/agents/openai.yaml ## Summary
- Add reference-set or eval evidence for the recently changed AI, analyzer, skill, agent, command, or harness guidance surface.
## Why
- Backfill eval, golden trace, benchmark, or reference-set evidence before another AI or harness-analysis change lands on the touched surface.
## Touched paths
- `.agents/skills/localization-paraglide/SKILL.md`
- `.agents/skills/localization-paraglide/agents/openai.yaml`
## Validation
- Add or update an eval, golden trace, benchmark, fixture, or reference-set artifact for the changed AI/harness behavior.
- Compare the changed behavior against the maintained reference set and record the pass/fail evidence.
- Confirm the follow-up evidence covers the same analyzer, skill, agent, command, or harness surface touched by this PR.analysis: add RAG/evaluator evidence for cmd/periscope/embeddings.go + cmd/periscope/embeddings_test.go ## Summary
- Add RAG/evaluator comparison evidence for the recently changed retrieval, ranking, embedding, or evaluator surface.
## Why
- Backfill reference-set comparison, golden trace, benchmark, or eval-run evidence before another RAG or evaluator change lands on the touched surface.
## Touched paths
- `cmd/periscope/embeddings.go`
- `cmd/periscope/embeddings_test.go`
## Validation
- Add or update an eval, reference set, golden trace, benchmark, fixture, or judge/scoring regression for the changed RAG/evaluator behavior.
- Compare the changed behavior against representative retrieval or evaluator cases and record pass/fail evidence.
- Confirm the follow-up evidence covers the same retrieval, embedding, ranking, or evaluator path touched by this PR.ci: add failure-mode evidence for .github/actions/build-desktop-artifact/action.yml + .github/workflows/bench-pr.yml ## Summary
- Add CI failure-mode evidence for the recently changed workflow or test-runner surface.
## Why
- Backfill CI failure-mode evidence before another workflow or test-runner change lands on the touched surface.
## Touched paths
- `.github/actions/build-desktop-artifact/action.yml`
- `.github/workflows/bench-pr.yml`
## Validation
- Add or update a CI failure fixture, captured failing log, troubleshooting note, workflow dry-run evidence, or regression test for the changed CI/test-runner behavior.
- Run the affected workflow or test-runner entrypoint locally or in CI and record pass/fail evidence.harness: add config quality evidence for .agents/skills/localization-paraglide/SKILL.md + .agents/skills/localization-paraglide/agents/openai.yaml ## Summary
- Add harness compatibility evidence for the recently changed config surface.
## Why
- Backfill harness audit, adapter matrix, or cross-harness compatibility evidence before another config change lands on the touched surface.
## Touched paths
- `.agents/skills/localization-paraglide/SKILL.md`
- `.agents/skills/localization-paraglide/agents/openai.yaml`
## Validation
- Run or update the harness audit, adapter compliance matrix, or cross-harness compatibility check for the changed config.
- Add or update a regression, fixture, or doc evidence path that covers the affected harness, MCP, plugin, or agent loading behavior.Detected Workflows (6)
Generated Instincts (33)
After merging, import with: Files
|
…d Layer 3 The history-preserving merge (32d3c28) overlaid merged scripts, README, and context UI onto the purified+PR26 tree, regressing CI that passed at ff8cd5b. Replay purified tree (read-tree) and overlay only merged paths purified lacks or needs superset for: ECC bundles (.claude/.agents/.codex), sync-upstream.sh, jetbrains-plugin, internal/summarize, internal/llm. Evaluated and rejected cherry-picking synthetic-pass commits — those replay merged-base trees and duplicate purified content. See docs/synthesis/OVERLAY_FIX.md. Verified locally: go test (root/build_script), make docs-check, npm check + kit-ui.
diazMelgarejo
marked this pull request as ready for review
July 29, 2026 09:09
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
* fix(duckdb-watch): add unwatched-root poller for local watch mode Local duckdb watch omitted the probe-gated authoritative poller that pg watch uses for deferred/unwatched roots. Deletions under those scopes were never tombstoned in SQLite or the DuckDB mirror because interval pushes only run SyncAll, which does not prove missed deletions. Mirror pg watch: share one sync engine with the watcher, register polling obligations for unwatched roots, and reconcile them via ReconcileWatchRoots. * refactor(duckdb-watch): address PR review nits — comment + shared test helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Experiment A — production path:
merged— Periscope fork Layer 3, context visualizer, ECC, release toolingcursor/agentsview-purified-onto-kenn-f559— kenn-io modernization replay + merged PR feat: upstream PR #23 stack onto purified (#1274 DuckDB + #1251 artifact + #1284 Omnigent) #26 (fix(cli): expand leading tilde in DuckDB mirror paths kenn-io/agentsview#1274 DuckDB + Add artifact publication ledger and export pipeline kenn-io/agentsview#1251 artifact + feat(parser): add Omnigent support kenn-io/agentsview#1284 Omnigent)Simulated merge inventory (2026-07-29)
6c3317ad(agentsviewmirror)Conflict hotspots (top)
cmd/periscopeinternal/syncinternal/serverinternal/postgresinternal/dbinternal/duckdbinternal/parserscripts/gitResolution doctrine (oramasys-method)
Per
docs/ARCHITECTURE.mdmatryoshka rules:sync-upstream.sh,jetbrains-plugin/, ECC bundles.verify-staged-for-commit.sh+ periscope copies.merged(PR feat(ecc): harmonize PR #24 ECC bundle onto current merged #25 precedent).History-preserving merge (2026-07-29)
Abandoned synthetic
synthesis(passN)commits (archived oncursor/agentsview-plus-periscope-synthetic-pass-f559). Adopted two-parent merge preserving real SHAs:git merge purified --no-commit --no-ffgit read-tree --reset -u purified^{tree}(passingff8cd5b3base)32d3c281records both parent SHAsSee
docs/synthesis/HISTORY_PRESERVING_MERGE.mdanddocs/synthesis/agentsview-plus-periscope-experiment-a.md.Companion experiment: PR #28
cursor/purified-plus-merged-f559→ purified (probe only — do not ship).Overlay fix (appended 2026-07-29)
Root cause: merge
32d3c281initially overlaid merged scripts/README/context onto purified+PR26, regressing CI that passed atff8cd5b3.Fix:
f963d00c/45dac3dd— tree replay from purified + minimal merged overlay only:scripts/sync-upstream.sh,jetbrains-plugin/,.claude/,.agents/,.codex/Options evaluated:
See
docs/synthesis/OVERLAY_FIX.md.