Conversation
Merged
dimikot
force-pushed
the
grok/dimikot/partially-switch-to-atomic-multi-branch-push-to-main-b4e5
branch
from
b4e5b68 to
3ad5f06
Compare
dimikot
added a commit
that referenced
this pull request
Apr 13, 2025
## Summary Several naming improvements in the code, plus debug logs improvement. ## How was this tested? CI. ## PRs in the Stack - #29 - ➡ #28 (The stack is managed by [git-grok](https://github.com/dimikot/git-grok).)
Base automatically changed from
grok/dimikot/nits-and-renames-to-main-8c41
to
main
April 13, 2025 10:02
dimikot
force-pushed
the
grok/dimikot/partially-switch-to-atomic-multi-branch-push-to-main-b4e5
branch
from
3ad5f06 to
1047d7e
Compare
Pull Request: #29 (main)
dimikot
force-pushed
the
grok/dimikot/partially-switch-to-atomic-multi-branch-push-to-main-b4e5
branch
from
1047d7e to
40112b9
Compare
This was referenced Apr 14, 2025
dimikot
deleted the
grok/dimikot/partially-switch-to-atomic-multi-branch-push-to-main-b4e5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding an engine which is able to push multiple branches (commits) atomically. For now, it still does most of the pushes sequentially, but using the parallel engine (with commits list size 1).
The problem is that multi-branch push can only be used safely when no commits reordering happened in the stack (otherwise, GitHub may mark some of intermediate PRs as merged prematurely, and there is no way out of it). That's why in the current PR, we do not utilize it much yet. It will be treated in the next PRs.
How was this tested?
CI.
PRs in the Stack
(The stack is managed by git-grok.)