Conversation
dimikot
force-pushed
the
grok/dimikot/improve-closed-prs-reopening-corner-cases-to-main-c887
branch
from
c887e44 to
e7fe862
Compare
dimikot
added a commit
that referenced
this pull request
Apr 14, 2025
## Summary Adding an engine which is able to push multiple branches (commits) atomically. For now, it still does most of the pushes sequentially, but using the parallel engine (with commits list size 1). The problem is that multi-branch push can only be used safely when no commits reordering happened in the stack (otherwise, GitHub may mark some of intermediate PRs as merged prematurely, and there is no way out of it). That's why in the current PR, we do not utilize it much yet. It will be treated in the next PRs. ## How was this tested? CI. ## PRs in the Stack - #31 - #30 - ➡ #29 (The stack is managed by [git-grok](https://github.com/dimikot/git-grok).)
Base automatically changed from
grok/dimikot/partially-switch-to-atomic-multi-branch-push-to-main-b4e5
to
main
April 14, 2025 10:25
Pull Request: #30 (main)
dimikot
force-pushed
the
grok/dimikot/improve-closed-prs-reopening-corner-cases-to-main-c887
branch
from
e7fe862 to
583b632
Compare
dimikot
deleted the
grok/dimikot/improve-closed-prs-reopening-corner-cases-to-main-c887
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub is "too smart", so sometimes it marks the PRs as merged or as closed on its own, right after the PR head branch is force-pushed:
We used to cover the case (1) (git-grok was just creating a new PR). Now we cover the case 2 (the same way as case 1) and case 3 (with a hack explained at isaacs/github#361).
How was this tested?
All those PRs were closed, then randomly reordered, and git-grok rerun:
PRs in the Stack
(The stack is managed by git-grok.)