feat(embassy-net): use the crate's API#58
Merged
diondokter merged 3 commits intodiondokter:masterfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
nponsard
force-pushed
the
fix-use-crate-api
branch
from
77b21e3 to
2cb3351
Compare
diondokter
approved these changes
Mar 20, 2026
Owner
diondokter
left a comment
diondokter
left a comment
There was a problem hiding this comment.
Cool, good changes!
Luckily I had made the error type non_exhaustive, so it's not a breaking change :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there is a better way in the crate to manage the LTE link, this changes the error type to use the parent one and uses LteLink to ensure the LTE part of the modem is powered up.