-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(builders): modal select menus in builders v1 #11138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
packages/builders/src/components/selectMenu/StringSelectMenu.ts
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## builders/1.x #11138 +/- ##
================================================
+ Coverage 37.41% 37.65% +0.23%
================================================
Files 237 240 +3
Lines 14773 15030 +257
Branches 1345 1346 +1
================================================
+ Hits 5528 5659 +131
- Misses 9201 9327 +126
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for modal select menus in builders v1 by introducing a new LabelBuilder
component and updating the modal system to support both traditional action rows and the new label components. The changes enable developers to create more flexible modal interfaces with labeled form controls.
Key changes:
- Introduces
LabelBuilder
for creating labeled form components in modals - Updates
ModalBuilder
to support both action rows and label components - Modifies text input and select menu components to work within the new label system
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
packages/builders/src/interactions/modals/Modal.ts | Updated modal builder to support label components alongside action rows |
packages/builders/src/components/label/Label.ts | New label builder implementation for modal form components |
packages/builders/src/components/textInput/TextInput.ts | Deprecated label property in favor of separate label builder |
packages/builders/src/components/selectMenu/BaseSelectMenu.ts | Added required field support for select menus in modals |
packages/builders/src/components/selectMenu/Assertions.ts | New validation predicates for select menu components |
packages/builders/src/components/Components.ts | Updated component factory to handle label components |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: