Skip to content

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Oct 5, 2025

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

@vladfrangu vladfrangu requested review from a team and iCrawl as code owners October 5, 2025 11:53
@vladfrangu vladfrangu requested review from Jiralite, didinele and kyranet and removed request for a team October 5, 2025 11:53
Copy link

vercel bot commented Oct 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 6, 2025 10:10pm
discord-js-guide Ignored Ignored Preview Oct 6, 2025 10:10pm

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Oct 6, 2025
@Jiralite Jiralite requested a review from a team as a code owner October 6, 2025 21:18
@Jiralite Jiralite requested review from SpaceEEC and removed request for a team October 6, 2025 21:18
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Oct 6, 2025
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 54.34783% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.65%. Comparing base (437bb94) to head (6906fec).
⚠️ Report is 1 commits behind head on builders/1.x.

Files with missing lines Patch % Lines
packages/builders/src/components/label/Label.ts 15.00% 68 Missing ⚠️
packages/builders/src/interactions/modals/Modal.ts 29.50% 43 Missing ⚠️
...s/builders/src/components/selectMenu/Assertions.ts 87.95% 10 Missing ⚠️
...ilders/src/components/selectMenu/BaseSelectMenu.ts 40.00% 3 Missing ⚠️
packages/builders/src/components/Components.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           builders/1.x   #11138      +/-   ##
================================================
+ Coverage         37.41%   37.65%   +0.23%     
================================================
  Files               237      240       +3     
  Lines             14773    15030     +257     
  Branches           1345     1346       +1     
================================================
+ Hits               5528     5659     +131     
- Misses             9201     9327     +126     
  Partials             44       44              
Flag Coverage Δ
builders 88.68% <54.34%> (-4.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite requested a review from Copilot October 6, 2025 22:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for modal select menus in builders v1 by introducing a new LabelBuilder component and updating the modal system to support both traditional action rows and the new label components. The changes enable developers to create more flexible modal interfaces with labeled form controls.

Key changes:

  • Introduces LabelBuilder for creating labeled form components in modals
  • Updates ModalBuilder to support both action rows and label components
  • Modifies text input and select menu components to work within the new label system

Reviewed Changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/builders/src/interactions/modals/Modal.ts Updated modal builder to support label components alongside action rows
packages/builders/src/components/label/Label.ts New label builder implementation for modal form components
packages/builders/src/components/textInput/TextInput.ts Deprecated label property in favor of separate label builder
packages/builders/src/components/selectMenu/BaseSelectMenu.ts Added required field support for select menus in modals
packages/builders/src/components/selectMenu/Assertions.ts New validation predicates for select menu components
packages/builders/src/components/Components.ts Updated component factory to handle label components
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Jiralite Jiralite merged commit ac683b9 into builders/1.x Oct 8, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Oct 8, 2025
@Jiralite Jiralite deleted the feat/modals-phase-1-2in-v14 branch October 8, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants