Skip to content

feat(builders): modal select menus in builders v1 #11138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 8, 2025
+672 −2,709

Apply suggestion from @Copilot

6906fec
Select commit
Loading
Failed to load commit list.
Merged

feat(builders): modal select menus in builders v1 #11138

Apply suggestion from @Copilot
6906fec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2025 in 1s

37.65% (+0.23%) compared to 437bb94

View this Pull Request on Codecov

37.65% (+0.23%) compared to 437bb94

Details

Codecov Report

❌ Patch coverage is 54.34783% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.65%. Comparing base (437bb94) to head (6906fec).

Files with missing lines Patch % Lines
packages/builders/src/components/label/Label.ts 15.00% 68 Missing ⚠️
packages/builders/src/interactions/modals/Modal.ts 29.50% 43 Missing ⚠️
...s/builders/src/components/selectMenu/Assertions.ts 87.95% 10 Missing ⚠️
...ilders/src/components/selectMenu/BaseSelectMenu.ts 40.00% 3 Missing ⚠️
packages/builders/src/components/Components.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           builders/1.x   #11138      +/-   ##
================================================
+ Coverage         37.41%   37.65%   +0.23%     
================================================
  Files               237      240       +3     
  Lines             14773    15030     +257     
  Branches           1345     1346       +1     
================================================
+ Hits               5528     5659     +131     
- Misses             9201     9327     +126     
  Partials             44       44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov