types(CommandInteractionOptionResolver): getChannels type fix#11380
types(CommandInteractionOptionResolver): getChannels type fix#11380Pavel-Boyazov wants to merge 1 commit intodiscordjs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
📝 WalkthroughWalkthroughUpdated the generic type constraint for two overloads of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)packages/discord.js/typings/index.d.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Need to fix tests, but other than that LGTM |
What's the best way to proceed? I've realized that for this change to work correctly, we need to modify type
Please let me know your preference. |
|
If we choose the first option, we need the |
|
The |
|
3 PRs. Sounds like fun 😅 Okay, got it |
Update. Discord allows to choose I don't have servers with directory to check this and don't know how to find them |
|
Bots aren't able to join servers with directory channnels. So this is irrelevant. Judging by your findings and the API documentation I'd say discord-api-types are correct and so were the typings. But the |
|
Will you turn this PR into a fix for |
Please describe the changes this PR makes and why it should be merged:
getChannels can't return channel types that not in allowed
Status and versioning classification:
Why no description template?..