Skip to content

types(CommandInteractionOptionResolver): getChannels type fix #11380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pavel-Boyazov wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Draft

types(CommandInteractionOptionResolver): getChannels type fix #11380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/discord.js/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,9 @@ export class CommandInteractionOptionResolver<Cached extends CacheType = CacheTy
* The `type` property of the {@link PublicThreadChannel} interface is typed as `ChannelType.PublicThread | ChannelType.AnnouncementThread`.
* If the user were to pass only one of those channel types, the `Extract<>` would resolve to `never`.
*/
public getChannel<const Type extends ChannelType = ChannelType>(
public getChannel<
const Type extends ApplicationCommandOptionAllowedChannelType = ApplicationCommandOptionAllowedChannelType,
>(
name: string,
required: true,
channelTypes?: readonly Type[],
Expand All @@ -1208,7 +1210,9 @@ export class CommandInteractionOptionResolver<Cached extends CacheType = CacheTy
* The `type` property of the {@link PublicThreadChannel} interface is typed as `ChannelType.PublicThread | ChannelType.AnnouncementThread`.
* If the user were to pass only one of those channel types, the `Extract<>` would resolve to `never`.
*/
public getChannel<const Type extends ChannelType = ChannelType>(
public getChannel<
const Type extends ApplicationCommandOptionAllowedChannelType = ApplicationCommandOptionAllowedChannelType,
>(
name: string,
required?: boolean,
channelTypes?: readonly Type[],
Expand Down
Loading