Skip to content

Update Korean translation#283

Merged
diwako merged 8 commits into
diwako:masterfrom
ins3821:master
May 31, 2026
Merged

Update Korean translation#283
diwako merged 8 commits into
diwako:masterfrom
ins3821:master

Conversation

@ins3821
Copy link
Copy Markdown
Contributor

@ins3821 ins3821 commented May 29, 2026

I don't know why not...

@diwako
Copy link
Copy Markdown
Owner

diwako commented May 29, 2026

I will take a look in a bit why this is failing. If you are fine with it, can I make modifications to your git branch to push the fixes?

@diwako
Copy link
Copy Markdown
Owner

diwako commented May 29, 2026

Ah I see the issue. The stringtable.xml in the main addon has duplicate entries for the Korean language. I usually sort them in a specific order, so it is uniform between all addons.
Git seems to have added the new order of things after you merged my current master branch into your repository.

Basically, not a bad thing. Tho I would recommend keeping your own master branch up to date in another way. Keep your master branch unmodified, so it is easy to sync it again.
To make changes, create a new branch, make your changes there, open a PR with the changed branch into this repository's master branch.

Then once you want to make more changes, or update missing string table entries, you can sync your master branch, create a new branch and start working.

Git is a bit confusing because of that. I did make the fixes on my end already, just waiting for your OK to push it to you.

@ins3821
Copy link
Copy Markdown
Contributor Author

ins3821 commented May 30, 2026

Yes, please go ahead! Thank you so much for figuring this out and for the helpful tip. I will make sure to use a separate branch for any future changes!

Wow. Thanks to you, I'm very familiar with how to use GitHub. Thank you.

@diwako
Copy link
Copy Markdown
Owner

diwako commented May 31, 2026

Yes, please go ahead! Thank you so much for figuring this out and for the helpful tip. I will make sure to use a separate branch for any future changes!

Wow. Thanks to you, I'm very familiar with how to use GitHub. Thank you.

Once this pull request has been merged, I would suggest just deleting the fork on your end and forking the repository again.

that is way easier than wrangle GIT to get it to the same state as this source repository.

@diwako diwako merged commit ad3e117 into diwako:master May 31, 2026
3 checks passed
@diwako diwako changed the title (Update Korean) stringtable.xml Update Korean translation May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants