Update Korean translation#283
Conversation
I have completed the Korean translation work.
|
I will take a look in a bit why this is failing. If you are fine with it, can I make modifications to your git branch to push the fixes? |
|
Ah I see the issue. The stringtable.xml in the main addon has duplicate entries for the Korean language. I usually sort them in a specific order, so it is uniform between all addons. Basically, not a bad thing. Tho I would recommend keeping your own master branch up to date in another way. Keep your master branch unmodified, so it is easy to sync it again. Then once you want to make more changes, or update missing string table entries, you can sync your master branch, create a new branch and start working. Git is a bit confusing because of that. I did make the fixes on my end already, just waiting for your OK to push it to you. |
|
Yes, please go ahead! Thank you so much for figuring this out and for the helpful tip. I will make sure to use a separate branch for any future changes! Wow. Thanks to you, I'm very familiar with how to use GitHub. Thank you. |
Once this pull request has been merged, I would suggest just deleting the fork on your end and forking the repository again. that is way easier than wrangle GIT to get it to the same state as this source repository. |
I don't know why not...