Fix retry loop skipping when AgentRunMaxRetries is negative

[Copilot]

Proposed changes

When AgentRunMaxRetries is set to a negative value (via config or CLI flag), the retry loop in GRPCClient.AgentRun would be skipped entirely (for attempt := 0; attempt <= maxRetries where maxRetries < 0). This causes lastErr to remain nil, and the function returns success without ever attempting to run the job.

Changes:

• Clamp maxRetries to 0 before the retry loop to guarantee at least one execution attempt
• Clamped value propagates to all derived fields (total_attempts in logs, backoff calculations)
• Fix unrelated syntax error in api_test.go (extra closing brace) that was blocking tests

maxRetries := grpcc.agent.config.AgentRunMaxRetries
// Clamp maxRetries to 0 if negative to ensure at least one attempt is made
if maxRetries < 0 {
    maxRetries = 0
}

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• 127.0.0.10
  • Triggering command: /tmp/go-build139554034/b001/dkron.test /tmp/go-build139554034/b001/dkron.test -test.testlogfile=/tmp/go-build139554034/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.run=TestGRPC .cfg ux_amd64/vet -p /kubernetes/type-l -lang=go1.24 ux_amd64/vet -o n47k/askgCWYVBoxX54Jan47k pkg/mod/k8s.io/api@v0.22.2/rbac/-ifaceassert ux_amd64/vet -p github.com/softl-l -lang=go1.16 ux_amd64/vet (packet block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}