Skip to content

Fix retry loop skipping when AgentRunMaxRetries is negative #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcastellm merged 2 commits into from
Jan 29, 2026
Merged

Fix retry loop skipping when AgentRunMaxRetries is negative #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acaba24
Initial plan
Copilot Jan 29, 2026
cdf1627
Fix retry loop to ensure at least one attempt when maxRetries is nega…
Copilot Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dkron/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,4 +638,3 @@ func TestHealthEndpoint(t *testing.T) {
assert.True(t, hasLeader, "health response should include leader field for server nodes")
}
}
}
4 changes: 4 additions & 0 deletions dkron/grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,10 @@ func (grpcc *GRPCClient) AgentRun(addr string, job *typesv1.Job, execution *type
defer metrics.MeasureSince([]string{"grpc_client", "agent_run"}, time.Now())

maxRetries := grpcc.agent.config.AgentRunMaxRetries
// Clamp maxRetries to 0 if negative to ensure at least one attempt is made
if maxRetries < 0 {
maxRetries = 0
}
initialInterval := grpcc.agent.config.AgentRunRetryInitialInterval
maxInterval := grpcc.agent.config.AgentRunRetryMaxInterval

Expand Down
Loading