Update rapids and mvn#91
Open
trivialfis wants to merge 3 commits into
Open
Conversation
trivialfis
temporarily deployed
to
containers-staging
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR updates CI/container build inputs by bumping RAPIDS to 26.06 and Maven to 3.9.16, while refactoring container setup to reuse shared scripts for CUDA package freezing (dnf versionlock) and gosu installation across multiple Docker images.
Changes:
- Add
setup_cuda_rockylinux.shto versionlock installed CUDA RPMs in RockyLinux-based CUDA images. - Add
install_gosu.shand update Dockerfiles to use it instead of duplicating gosu download logic. - Update RAPIDS stable version to
26.06and Maven to3.9.16.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| containers/scripts/setup_cuda_rockylinux.sh | New helper to import NVIDIA GPG key, versionlock installed CUDA RPMs, and run dnf update/config. |
| containers/scripts/install_gosu.sh | New helper to install gosu in a centralized, arch-aware way. |
| containers/dockerfile/Dockerfile.manylinux2014_x86_64 | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.manylinux2014_aarch64 | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.manylinux_2_28_x86_64 | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.manylinux_2_28_aarch64 | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.jvm_gpu_build | Bump Maven; use shared CUDA setup + gosu install scripts. |
| containers/dockerfile/Dockerfile.jvm | Bump Maven; use shared gosu install script. |
| containers/dockerfile/Dockerfile.i386 | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.gpu_build_rockylinux8 | Use shared CUDA setup + gosu install scripts. |
| containers/dockerfile/Dockerfile.gpu_build_r_rockylinux8 | Use shared CUDA setup + gosu install scripts. |
| containers/dockerfile/Dockerfile.gpu_build_cuda13_rockylinux8 | Use shared CUDA setup + gosu install scripts. |
| containers/dockerfile/Dockerfile.gpu | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.cpu_build_r_doc | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.cpu | Switch gosu installation to shared script. |
| containers/dockerfile/Dockerfile.clang_tidy | Switch gosu installation to shared script. |
| containers/ci_container.yml | Update RAPIDS stable version anchor to 26.06. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| dnf -y install dnf-plugins-core python3-dnf-plugin-versionlock | ||
|
|
||
| CUDA_SHORT_DASHED=$(echo "${CUDA_VERSION}" | grep -o -E '[0-9]+\.[0-9]' | tr . -) |
Comment on lines
+26
to
+35
| gosu_url="https://github.com/tianon/gosu/releases/download/${GOSU_VERSION}/gosu-${gosu_arch}" | ||
|
|
||
| if command -v wget >/dev/null 2>&1; then | ||
| wget -nv -O /usr/local/bin/gosu "${gosu_url}" | ||
| elif command -v curl >/dev/null 2>&1; then | ||
| curl -fsSL -o /usr/local/bin/gosu "${gosu_url}" | ||
| else | ||
| echo "Either wget or curl is required to install gosu" >&2 | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #90 .