Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 27, 2025

dmno resolve --format env was serializing undefined values as KEY="undefined" while --format json correctly excluded them. This inconsistency caused invalid env file output.

Changes:

  • Filter undefined values in stringifyObjectAsEnvFile before serialization
  • Add test coverage for undefined value handling

Before:

$ dmno resolve --format env
BILLING_TEAMS_HOOK_URL="undefined"

After:

$ dmno resolve --format env
# BILLING_TEAMS_HOOK_URL excluded from output

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.iconify.design

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG]: undefined items in env format output</issue_title>
<issue_description>### dmno version

0.0.39

Steps to reproduce

Image

What is expected?

keys with undefined values should not be present in dmno resolve --format env

What is actually happening?

actual output is KEY="undefined"

System Info

Any additional comments?

No response</issue_description>

<agent_instructions>make the dmno resolve --format env output also exclude any undefined items as it does for the json output</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: e7974ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dmno Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI changed the title [WIP] Fix output for undefined items in env format Filter undefined values from env format output Oct 27, 2025
Copilot finished work on behalf of philmillman October 27, 2025 14:53
Copilot AI requested a review from philmillman October 27, 2025 14:53
@philmillman philmillman marked this pull request as ready for review October 27, 2025 14:57
@philmillman philmillman added bug Something isn't working core labels Oct 27, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 27, 2025

Open in StackBlitz

npm i https://pkg.pr.new/dmno@235

commit: e7974ca

@theoephraim theoephraim merged commit 2681e77 into main Oct 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working community core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: undefined items in env format output

3 participants