Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tasty-paws-cover.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"dmno": patch
---

Remove undefined items from `dmno resolve --format env` output
2 changes: 1 addition & 1 deletion .github/workflows/release-preview.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Install node deps
run: pnpm i
- name: Enable turborepo build cache
uses: rharkor/caching-for-turbo@v1.5
uses: rharkor/caching-for-turbo@v2.3.2
- name: Build publishable DMNO modules
run: pnpm build:libs

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Install node deps
run: pnpm i
- name: Enable turborepo build cache
uses: rharkor/caching-for-turbo@v1.5
uses: rharkor/caching-for-turbo@v2.3.2
- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@v1
Expand Down
4 changes: 4 additions & 0 deletions packages/core/src/cli/lib/env-file-helpers.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,8 @@ describe('stringifyObjectAsEnvFile', () => {
const result = stringifyObjectAsEnvFile({ foo: 'bar"baz' });
expect(result).toEqual('foo="bar\\"baz"');
});
test('excludes undefined values', () => {
const result = stringifyObjectAsEnvFile({ foo: 'bar', baz: undefined, qux: 'test' });
expect(result).toEqual('foo="bar"\nqux="test"');
});
});
18 changes: 10 additions & 8 deletions packages/core/src/cli/lib/env-file-helpers.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
export function stringifyObjectAsEnvFile(obj: Record<string, any>) {
return Object.entries(obj).map(([key, value]) => {
// Handle newlines and quotes by wrapping in double quotes and escaping
const formattedValue = String(value)
.replace(/\\/g, '\\\\') // escape backslashes first
.replace(/\n/g, '\\n') // escape newlines
.replace(/"/g, '\\"'); // escape double quotes
return Object.entries(obj)
.filter(([_key, value]) => value !== undefined) // Exclude undefined values
.map(([key, value]) => {
// Handle newlines and quotes by wrapping in double quotes and escaping
const formattedValue = String(value)
.replace(/\\/g, '\\\\') // escape backslashes first
.replace(/\n/g, '\\n') // escape newlines
.replace(/"/g, '\\"'); // escape double quotes

return `${key}="${formattedValue}"`;
}).join('\n');
return `${key}="${formattedValue}"`;
}).join('\n');
}