Fix JSON casing for catalogRef to match camelCase convention#445
Merged
cutecatfann merged 1 commit intomainfrom Mar 16, 2026
Merged
Fix JSON casing for catalogRef to match camelCase convention#445cutecatfann merged 1 commit intomainfrom
cutecatfann merged 1 commit intomainfrom
Conversation
austin5456
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
workingset.Server.CatalogReffromcatalog_reftocatalogRefto match the camelCase convention used throughout the JSON response (likedisplayName,longLived,allowHostsin the nestedsnapshot.server)db.ServerJSON tag ascatalog_refsince that controls SQLite storage serialization; changing it would break deserialization of already-persisted datacatalog_ref(snake_case is standard YAML convention)Follow-up to #441. Austin flagged that the new field was snake_case while the rest of the JSON response uses camelCase. The
NewFromDb/ToDbmapping between db and workingset layers uses Go field names, so the JSON tag mismatch between layers is safe.Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did