Skip to content

Fix JSON casing for catalogRef to match camelCase convention #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cutecatfann merged 1 commit into from
Mar 16, 2026
+4 −4
Merged

Fix JSON casing for catalogRef to match camelCase convention #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/workingset/show_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ func TestShowWithCatalogRef(t *testing.T) {
})
require.NoError(t, err)

t.Run("JSON includes catalog_ref", func(t *testing.T) {
t.Run("JSON includes catalogRef", func(t *testing.T) {
output := captureStdout(func() {
err := Show(ctx, dao, "test-set", OutputFormatJSON, false, "")
require.NoError(t, err)
Expand All @@ -611,8 +611,8 @@ func TestShowWithCatalogRef(t *testing.T) {
assert.Equal(t, "docker.io/mcp/docker-mcp-catalog:latest", workingSet.Servers[0].CatalogRef)
assert.Empty(t, workingSet.Servers[1].CatalogRef)

// Verify catalog_ref appears in raw JSON for server with source
assert.Contains(t, output, `"catalog_ref"`)
// Verify catalogRef appears in raw JSON for server with source
assert.Contains(t, output, `"catalogRef"`)
})

t.Run("YAML includes catalog_ref", func(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/workingset/workingset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ type Server struct {

// CatalogRef is the catalog reference that this server was sourced from.
// Empty if the server was added directly (not from a catalog).
CatalogRef string `yaml:"catalog_ref,omitempty" json:"catalog_ref,omitempty"`
CatalogRef string `yaml:"catalog_ref,omitempty" json:"catalogRef,omitempty"`

// Optional snapshot of the server schema
Snapshot *ServerSnapshot `yaml:"snapshot,omitempty" json:"snapshot,omitempty"`
Expand Down
Loading