Add TEST_ONLY build arg for each distro#251
Conversation
crazy-max
force-pushed
the
filter-distros
branch
from
7830b92 to
f183e53
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
filter-distros
branch
from
f183e53 to
6ad3358
Compare
crazy-max
changed the title
crazy-max
changed the title
| DISTRO_ID = "" | ||
| DISTRO_SUITE = "" | ||
| DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "debian:bookworm" | ||
| TEST_ONLY = "0" |
There was a problem hiding this comment.
Silly thought; would it make sense to do the reverse, i.e. currently it's opt-out when adding a distro; wondering if it should be "opt-in" to be deployed.
Or we could even have a CHANNELS param to allow having upcoming distros in our test channel, but not in stable.
There was a problem hiding this comment.
Or we could even have a
CHANNELSparam to allow having upcoming distros in our test channel, but not in stable.
Yeah this is basically what it does, except less mouthy. TEST_ONLY will just deploy to test channel.
There was a problem hiding this comment.
Oh! I thought it was "test in CI only, but don't deploy"
FWIW, we had some examples of that in the other repositories, where we test "Fedora Rawhide" and "Debian sid" (testing) in CI.
Those should never, ever be deployed (not even in the "test" channel), but are good to have to validate if upcoming distro releases need changes in packaging.
So that was my thinking behind a "channels" arg; which could be empty if a distro should not be deployed at all
3 participants
alternative to and closes #245