Skip to content

Add TEST_ONLY build arg for each distro #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazy-max merged 1 commit into from
Aug 20, 2025
Merged

Add TEST_ONLY build arg for each distro #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions docker-bake.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ target "_distro-static" {
DISTRO_ID = ""
DISTRO_SUITE = ""
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "debian:bookworm"
TEST_ONLY = "0"
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly thought; would it make sense to do the reverse, i.e. currently it's opt-out when adding a distro; wondering if it should be "opt-in" to be deployed.

Or we could even have a CHANNELS param to allow having upcoming distros in our test channel, but not in stable.

Copy link
Copy Markdown
Collaborator

@vvoland vvoland Aug 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we could even have a CHANNELS param to allow having upcoming distros in our test channel, but not in stable.

Yeah this is basically what it does, except less mouthy. TEST_ONLY will just deploy to test channel.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I thought it was "test in CI only, but don't deploy"

FWIW, we had some examples of that in the other repositories, where we test "Fedora Rawhide" and "Debian sid" (testing) in CI.

Those should never, ever be deployed (not even in the "test" channel), but are good to have to validate if upcoming distro releases need changes in packaging.

So that was my thinking behind a "channels" arg; which could be empty if a distro should not be deployed at all

}
}

Expand All @@ -186,6 +187,7 @@ target "_distro-debian11" {
DISTRO_ID = "11"
DISTRO_SUITE = "bullseye"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "debian:bullseye"
TEST_ONLY = "0"
}
}

Expand All @@ -197,6 +199,7 @@ target "_distro-debian12" {
DISTRO_ID = "12"
DISTRO_SUITE = "bookworm"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "debian:bookworm"
TEST_ONLY = "0"
}
}

Expand All @@ -208,6 +211,7 @@ target "_distro-debian13" {
DISTRO_ID = "13"
DISTRO_SUITE = "trixie"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "debian:trixie"
TEST_ONLY = "0"
}
}

Expand All @@ -219,6 +223,7 @@ target "_distro-raspbian11" {
DISTRO_ID = "11"
DISTRO_SUITE = "bullseye"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "balenalib/rpi-raspbian:bullseye"
TEST_ONLY = "0"
}
}

Expand All @@ -230,6 +235,7 @@ target "_distro-raspbian12" {
DISTRO_ID = "12"
DISTRO_SUITE = "bookworm"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "balenalib/rpi-raspbian:bookworm"
TEST_ONLY = "0"
}
}

Expand All @@ -241,6 +247,7 @@ target "_distro-ubuntu2204" {
DISTRO_ID = "22.04"
DISTRO_SUITE = "jammy"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "ubuntu:jammy"
TEST_ONLY = "0"
}
}

Expand All @@ -252,6 +259,7 @@ target "_distro-ubuntu2404" {
DISTRO_ID = "24.04"
DISTRO_SUITE = "noble"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "ubuntu:noble"
TEST_ONLY = "0"
}
}

Expand All @@ -263,6 +271,7 @@ target "_distro-ubuntu2410" {
DISTRO_ID = "24.10"
DISTRO_SUITE = "oracular"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "ubuntu:oracular"
TEST_ONLY = "0"
}
}

Expand All @@ -274,6 +283,7 @@ target "_distro-ubuntu2504" {
DISTRO_ID = "25.04"
DISTRO_SUITE = "plucky"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "ubuntu:plucky"
TEST_ONLY = "0"
}
}

Expand All @@ -285,6 +295,7 @@ target "_distro-almalinux8" {
DISTRO_ID = "8"
DISTRO_SUITE = "8"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "almalinux:8"
TEST_ONLY = "1"
}
}

Expand All @@ -296,6 +307,7 @@ target "_distro-almalinux9" {
DISTRO_ID = "9"
DISTRO_SUITE = "9"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "almalinux:9"
TEST_ONLY = "1"
}
}

Expand All @@ -307,6 +319,7 @@ target "_distro-centos9" {
DISTRO_ID = "9"
DISTRO_SUITE = "9"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "quay.io/centos/centos:stream9"
TEST_ONLY = "0"
}
}

Expand All @@ -318,6 +331,7 @@ target "_distro-centos10" {
DISTRO_ID = "10"
DISTRO_SUITE = "10"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "quay.io/centos/centos:stream10"
TEST_ONLY = "0"
}
}

Expand All @@ -329,6 +343,7 @@ target "_distro-fedora41" {
DISTRO_ID = "41"
DISTRO_SUITE = "41"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "fedora:41"
TEST_ONLY = "0"
}
}

Expand All @@ -340,6 +355,7 @@ target "_distro-fedora42" {
DISTRO_ID = "42"
DISTRO_SUITE = "42"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "fedora:42"
TEST_ONLY = "0"
}
}

Expand All @@ -351,6 +367,7 @@ target "_distro-oraclelinux8" {
DISTRO_ID = "8"
DISTRO_SUITE = "8"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "oraclelinux:8"
TEST_ONLY = "1"
}
}

Expand All @@ -362,6 +379,7 @@ target "_distro-oraclelinux9" {
DISTRO_ID = "9"
DISTRO_SUITE = "9"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "oraclelinux:9"
TEST_ONLY = "1"
}
}

Expand All @@ -373,6 +391,7 @@ target "_distro-rhel8" {
DISTRO_ID = "8"
DISTRO_SUITE = "8"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "registry.access.redhat.com/ubi8/ubi"
TEST_ONLY = "0"
}
}

Expand All @@ -384,6 +403,7 @@ target "_distro-rhel9" {
DISTRO_ID = "9"
DISTRO_SUITE = "9"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "registry.access.redhat.com/ubi9/ubi"
TEST_ONLY = "0"
}
}

Expand All @@ -395,6 +415,7 @@ target "_distro-rockylinux8" {
DISTRO_ID = "8"
DISTRO_SUITE = "8"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "rockylinux/rockylinux:8"
TEST_ONLY = "1"
}
}

Expand All @@ -406,6 +427,7 @@ target "_distro-rockylinux9" {
DISTRO_ID = "9"
DISTRO_SUITE = "9"
DISTRO_IMAGE = DISTRO_IMAGE != null && DISTRO_IMAGE != "" ? DISTRO_IMAGE : "rockylinux/rockylinux:9"
TEST_ONLY = "1"
}
}

Expand Down