Populate foreign key constraint options only with non-default values

[morozov]

The current implementation if ForeignKeyConstraintEditor::create() populates the match, onUpdate and onDelete options of the foreign key constraints even if they weren't explicitly set and thus are equal to their default values.

This is correct – the default options match to the corresponding defaults in SQL. The "problem" is that if a table is constructed via the editor, its CREATE TABLE SQL will explicitly contain the default clauses like ON UPDATE NO ACTION. Functionally, this is still not a problem, I just want to keep the behavior of the editor such that switching the implementation of the table construction doesn't change the generated SQL.

The second problem is auto-generated index names for quoted columns. This issue is tracked in #6733 – the resulting auto-generated name depends on the quote character used to declare a quoted name. Since TableEditor internally uses Identifier::toString() which in turn uses double quotes, switching from new Table() with backticks to TableEditor would result in different auto-generated name. This is inevitable. I've extracted this into a separate commit to demonstrate that this is an existing issue, and the change is test-only.

[greg0ire]

To make sure I understand, in 95039c4 you wanted to use the ForeignKeyConstraintEditor in a test, but couldn't because it generated different SQL than the previous implementation, is that correct? If yes this looks OK to me.

[morozov]

Yes. If 95039c4 is reverted, the reworked test will fail as follows:

There were 9 failures:

1) Doctrine\DBAL\Tests\Platforms\DB2PlatformTest::testQuotedColumnInForeignKeyPropagation
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
     1 => 'ALTER TABLE "quoted" ADD CONS...-bar")'
     2 => 'ALTER TABLE "quoted" ADD CONS...-bar")'
     3 => 'ALTER TABLE "quoted" ADD CONS...-bar")'
-    4 => '..._22660D028FD6E0FB8C736521D79164E3 ON "quoted" ("create", foo, "bar")'
+    4 => '..._22660D028FD6E0FB8C7365216D704F76 ON "quoted" ("create", foo, "bar")'
 )

/Users/morozov/Projects/dbal/tests/Platforms/AbstractPlatformTestCase.php:480