Add regression test for dirty ReferenceMany collection change detection - #3021
Merged
GromNaN merged 1 commit intoJun 29, 2026
Merged
Conversation
Ensures that a ReferenceMany PersistentCollection marked as dirty (same instance, new element added) is detected as changed by computeChangeSets(). Unlike EmbedMany, ReferenceMany collections are excluded from the association changeset loop, so detection relies solely on the dirty flag check in computeOrRecomputeChangeSet().
malarzm
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeOrRecomputeChangeSet()must detect aReferenceManyPersistentCollectionas changed when it is dirty (same instance, element added or removed). UnlikeEmbedManycollections,ReferenceManyare explicitly skipped in the association changeset loop (line 879 ofUnitOfWork.php), so detection relies solely on the dirty flag check in the field comparison block.This test covers a regression introduced by #3017, where replacing the
$orgValue === $actualValueguard withspl_object_hash()— functionally equivalent for live objects — causes the dirty collection to be skipped instead of falling through to the changeset.