Skip to content

Add regression test for dirty ReferenceMany collection change detection #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GromNaN merged 1 commit into from
Jun 29, 2026
Merged

Add regression test for dirty ReferenceMany collection change detection #3021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/Tests/UnitOfWorkTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
use Documents\ForumStar;
use Documents\ForumUser;
use Documents\Functional\NotSaved;
use Documents\Group;
use Documents\User;
use MongoDB\BSON\ObjectId;
use MongoDB\Collection as MongoDBCollection;
Expand Down Expand Up @@ -489,6 +490,25 @@ public function testEmbeddedDocumentChangeSets(): void
self::assertEquals('Nashville', $changeSet['city'][1]);
}

public function testDirtyReferenceManyCollectionIsDetectedAsChanged(): void
{
$group = new Group('Admins');
$user = new User();
$this->uow->persist($group);
$this->uow->persist($user);
$this->uow->commit();

// Add a reference to the same PersistentCollection instance (orgValue === actualValue, but dirty).
// ReferenceMany collections are not processed through the association changeset loop,
// so their detection relies solely on the dirty flag in computeOrRecomputeChangeSet().
$user->addGroup($group);

$this->uow->computeChangeSets();
$changeSet = $this->uow->getDocumentChangeSet($user);

self::assertArrayHasKey('groups', $changeSet);
}

public function testRecomputeChangesetForUninitializedProxyDoesNotCreateChangeset(): void
{
$user = new ForumUser();
Expand Down