Fix MSB4086 if LangVersion is a keyword #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation error MSB4086 if LangVersion is already set to one of the keywords such as preview, latest and latestMajor. Otherwise MSBuild complains that it cannot perform a numeric comparison.
adamsitnik
approved these changes
Apr 9, 2020
|
@eerhardt could you please take a look? I want to make sure that it's the best fix possible (it looks good to me) |
eerhardt
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
I think the fix looks good.
The only other possibility I could imagine would be using the new functionality in dotnet/msbuild#4911: $([MSBuild]::VersionLessThan(a, b)). But I don't think there is a IsVersion or TryParse kind of method there. So I think what we have here is fine.
|
@eerhardt thank you! |
|
@AndreyAkinshin this bug fix and the Xamarin support make it a very good candidates to release 0.12.2 :D |
This was referenced Oct 20, 2020
Closed
lipchev
added a commit
to lipchev/UnitsNet
that referenced
this pull request
Apr 26, 2021
there is no end to it... dotnet/BenchmarkDotNet#1420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation error MSB4086 with version 0.12.1 if the
LangVersionMSBuild property is already set to one of the keywords such aspreview,latestandlatestMajor(docs).Otherwise MSBuild complains that it cannot perform a numeric comparison and compilation fails.
Example compilation error from a project with
<LangVersion>latest</LangVersion>specified in aDirectory.Build.propsfile in the repository root:Open to alternative suggestions for the fix, but I've gone with just checking whether the first character of the existing value is a digit (implying it's a version number) before performing the comparison. Otherwise it assumes that the keyword resolves to a version greater than 7.3.
I'm also not sure on what the best way to add a regression test for this, again open to suggestions.
Issue appears to have been introduced by #1389 (d02c8c3).