Handle assemblies loaded via a stream #1443
Conversation
…h is empty. This can occur if an assembly is loaded via a stream (https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assembly.location).
|
|
…d cause an exception to be throw.
There was a problem hiding this comment.
Thank you for your PR, it looks good to me.
One thing that I am not sure of is the next part of generating the project.
To be able to build the auto-generated project it must reference the project that defines benchmarks.
We search for the project file using this method. If we can't find it, BDN throws.
After we find the path to .csproj we fill the project template:
Before I merge your PR I would like to make sure that this part works for you scenario. Could you please verify that? One way to test it would be to edit your benchmarks and reference BenchmarkDotNet.csproj instead of the NuGet package. Other would be to run dotnet pack -c Release in BenchmarkDotNet\src\BenchmarkDotNet\, take the generated .nuspec file, move it to some folder and add this folder to the nuget.config file of your project and just install it from your IDE.
Thank you,
Adam
| //Simulate loading an assembly from a stream | ||
| var benchmarkDotNetAssembly = typeof(MockFactory.MockBenchmarkClass).GetTypeInfo().Assembly; | ||
| var streamLoadedAssembly = Assembly.Load(File.ReadAllBytes(benchmarkDotNetAssembly.Location)); | ||
| var assemblyType = streamLoadedAssembly.GetRunnableBenchmarks().Select(type => type).FirstOrDefault(); |
Co-authored-by: Adam Sitnik <[email protected]>
Co-authored-by: Adam Sitnik <[email protected]>
|
Thanks for the feedback. I followed the instructions to generate a nuget spec using
Thanks, |
Hello,
We are using a test framework called Gauge (https://gauge.org/) to do regression testing and wanted to roll performance tests in with those regression tests. In our case we want to use Gauge steps to control and kick off different BenchmarkDotNet benchmarks (so we have a common top level framework for all of our regression tests).
One issue we have run into is Gauge loads assemblies via streams, this causes the assembly location to be an empty string when running against net core/net standard. More information about the assembly location being empty in this case can be found in Microsoft's documentation (https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assembly.location).
This PR provides a way to handle that scenario by providing a default location for the project build artifacts. Other non-CsProjGenerators seem to do this by default so we have only updated this generator.
It's possible this could be handled a different way, but we've found this solution is working well for us.
Any feedback is welcomed.