Inhibit code coverage upload for ADO.Net pipelines#3828
Merged
Conversation
- Added CredScan suppressions for test files that contain legitimate secrets. - Added pipeline variable to control whether or not we upload code coverage results.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces pipeline configuration changes to control code coverage uploads and adds CredScan suppressions for legitimate test secrets.
- Adds a new pipeline variable
ci_var_uploadTestResultthat controls whether code coverage results are uploaded to CodeCov - Removes the default value from the
uploadparameter in the code coverage job template, making it a required parameter - Adds CredScan suppressions for test files containing legitimate test certificates and passwords used in Always Encrypted tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Adds detailed comments and passes the ci_var_uploadTestResult pipeline variable to the code coverage job's upload parameter |
| eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml | Removes the default: true value from the upload parameter, making it required |
| .config/CredScanSuppressions.json | Adds suppressions for two test files: a fixture class containing test passwords and a test certificate PFX file |
paulmedynski
commented
Dec 5, 2025
Contributor
Author
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
Commentary for reviewers.
cheenamalhotra
approved these changes
Dec 5, 2025
apoorvdeshmukh
approved these changes
Dec 5, 2025
benrr101
approved these changes
Dec 5, 2025
apoorvdeshmukh
added a commit
that referenced
this pull request
Jan 13, 2026
samsharma2700
added a commit
that referenced
this pull request
Jan 13, 2026
cheenamalhotra
pushed a commit
that referenced
this pull request
Jan 14, 2026
samsharma2700
added a commit
that referenced
this pull request
Jan 14, 2026
samsharma2700
added a commit
that referenced
this pull request
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description