-
Notifications
You must be signed in to change notification settings - Fork 610
AzureStorage auto create queues #9137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds support for auto-creating and deep linking to individual Azure Storage queues along with associated tests and configuration changes. Key changes include adding new settings and client extensions for Azure queues, updating configuration bindings and health checks, and integrating new queue-based provisioning in the hosting layer.
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/Aspire.Azure.Storage.Queues.Tests/ConformanceTests.cs | Added test support to configure options for queues. |
tests/Aspire.Azure.Storage.Queues.Tests/AzureBlobStorageContainerSettingsTests.cs | Introduces tests for connection string parsing for queue settings but the file name implies blob container settings. |
src/Components/Aspire.Azure.Storage.Queues/AzureStorageQueuesSettings.cs | Changed the Azure queues settings from sealed to non-sealed. |
src/Components/Aspire.Azure.Storage.Queues/AzureStorageQueueSettings.cs | Added connection string parsing logic for queue settings. |
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.cs | Updated extension methods for registering queue and keyed queue clients. |
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.StorageQueueComponent.cs | Added client registration for single queue operations with a potential error message discrepancy. |
src/Aspire.Hosting.Azure.Storage/AzureStorageExtensions.cs | Updated storage resource provisioning to include queues. |
src/Aspire.Hosting.Azure.Storage/AzureQueueStorageResource.cs & AzureQueueStorageQueueResource.cs | Added resource representations and provisioning conversions for queues. |
playground/* | Updated sample applications and functions to use the new queue registrations and naming conventions. |
Files not reviewed (1)
- src/Aspire.Hosting.Azure.Storage/Aspire.Hosting.Azure.Storage.csproj: Language not supported
Comments suppressed due to low confidence (1)
tests/Aspire.Azure.Storage.Queues.Tests/AzureBlobStorageContainerSettingsTests.cs:11
- The file is named 'AzureBlobStorageContainerSettingsTests.cs' but the class under test is 'AzureStorageQueueSettingsTests'. Consider renaming the file to match the tested subject for clarity.
public class AzureStorageQueueSettingsTests
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.cs
Outdated
Show resolved
Hide resolved
...Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.StorageQueueComponent.cs
Outdated
Show resolved
Hide resolved
resource queues 'Microsoft.Storage/storageAccounts/queueServices@2024-01-01' = { | ||
parent: storage | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This change is, essentially, a copy of #9008 adapter for Azure storage queues.
Addendum to #5167
Checklist
<remarks />
and<code />
elements on your triple slash comments?doc-idea
templatebreaking-change
templatediagnostic
template