Skip to content

AzureStorage auto create queues #9137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented May 7, 2025

Description

  • Add the ability to register and deep link to individual Azure storage queues.
  • Auto-create Azure storage queues upon registration.

This change is, essentially, a copy of #9008 adapter for Azure storage queues.

Addendum to #5167

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@RussKie RussKie self-assigned this May 7, 2025
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label May 7, 2025
@RussKie RussKie changed the title Clean up AzureStorage auto create queues May 7, 2025
@RussKie RussKie requested review from davidfowl, captainsafia and Copilot and removed request for radical, sebastienros and eerhardt May 7, 2025 09:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for auto-creating and deep linking to individual Azure Storage queues along with associated tests and configuration changes. Key changes include adding new settings and client extensions for Azure queues, updating configuration bindings and health checks, and integrating new queue-based provisioning in the hosting layer.

Reviewed Changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/Aspire.Azure.Storage.Queues.Tests/ConformanceTests.cs Added test support to configure options for queues.
tests/Aspire.Azure.Storage.Queues.Tests/AzureBlobStorageContainerSettingsTests.cs Introduces tests for connection string parsing for queue settings but the file name implies blob container settings.
src/Components/Aspire.Azure.Storage.Queues/AzureStorageQueuesSettings.cs Changed the Azure queues settings from sealed to non-sealed.
src/Components/Aspire.Azure.Storage.Queues/AzureStorageQueueSettings.cs Added connection string parsing logic for queue settings.
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.cs Updated extension methods for registering queue and keyed queue clients.
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.StorageQueueComponent.cs Added client registration for single queue operations with a potential error message discrepancy.
src/Aspire.Hosting.Azure.Storage/AzureStorageExtensions.cs Updated storage resource provisioning to include queues.
src/Aspire.Hosting.Azure.Storage/AzureQueueStorageResource.cs & AzureQueueStorageQueueResource.cs Added resource representations and provisioning conversions for queues.
playground/* Updated sample applications and functions to use the new queue registrations and naming conventions.
Files not reviewed (1)
  • src/Aspire.Hosting.Azure.Storage/Aspire.Hosting.Azure.Storage.csproj: Language not supported
Comments suppressed due to low confidence (1)

tests/Aspire.Azure.Storage.Queues.Tests/AzureBlobStorageContainerSettingsTests.cs:11

  • The file is named 'AzureBlobStorageContainerSettingsTests.cs' but the class under test is 'AzureStorageQueueSettingsTests'. Consider renaming the file to match the tested subject for clarity.
public class AzureStorageQueueSettingsTests

Comment on lines +29 to +31
resource queues 'Microsoft.Storage/storageAccounts/queueServices@2024-01-01' = {
parent: storage
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is broken. The required property name is unset and there's no way to set it...

image
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants