redis force-reconnect; fix release failure scenario #52608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgravell
added
the
feature-caching
dotnet-issue-labeler
bot
added
the
area-networking
amcasey
added
the
area-middleware
adityamandaleeka
approved these changes
Dec 7, 2023
|
Should this go into 8.0 servicing as well? |
|
@adityamandaleeka might as well, as a minor bugfix; I'll kick off a backport |
ghost
added this to the
|
@mgravell sounds good. You should be able to use the bot to backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nit bugfix; redis caching with "force reconnect" enabled (feature flag) resets the connection in some error scenarios; it does this with a
CompareExchange, but incorrectly it releases the result of this (the old value of_cache) irrespective of the outcome; it should test whether this was what we expected, and only release the connection if we have actively wiped the connectionproblematic scenario (impossible to reproduce on demand):
cacheis snapshotted as a non-nullvalue_cacheisn't still the same reference as we hold incachewith the fix, we capture the response of
CompareExchangeand only release the connection if it matches the value we were thinking of, i.e. we have successfully swapped the connection out tonull