Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching SERedis critical bugfix; defer HC metadata detection because of DI cycle #60915

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

mgravell
Copy link
Member

@mgravell mgravell commented Mar 13, 2025

Caching SERedis critical bugfix; defer HC metadata detection because of DI cycle

fix #60894

Existing HybridCache metadata detection can create a DI cycle, infinite loop and eventual stack-overflow

Fix this by deferring detection until after construction.

Workaround for now is simply not to use 9.0.3:

- <PackageReference Include="Microsoft.Extensions.Caching.StackExchangeRedis" Version="9.0.3" />
+ <PackageReference Include="Microsoft.Extensions.Caching.StackExchangeRedis" Version="9.0.2" />

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Mar 13, 2025
@mgravell
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/13836539030

@mgravell mgravell enabled auto-merge (squash) March 13, 2025 15:50
@mgravell mgravell merged commit 8ee12ef into main Mar 13, 2025
27 checks passed
@mgravell mgravell deleted the marc/hc_di_fix branch March 13, 2025 16:28
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-caching Includes: StackExchangeRedis and SqlServer distributed caches
Projects
None yet
3 participants