Skip to content

Fix Aspire Dashboard product version resolution in update-dependencies #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbussell merged 1 commit into from
Nov 19, 2025
Merged

Fix Aspire Dashboard product version resolution in update-dependencies #6831

lbussell merged 1 commit into from
Nov 19, 2025

Conversation

@lbussell
Copy link
Member

@lbussell lbussell commented Nov 18, 2025

Related: #6830

The product version calculation for Aspire Dashboard introduced in #6726 was slightly incorrect. This PR fixes it.

Before this change:

    "aspire-dashboard|build-version": "13.1.0-preview.1.25568.1",
    "aspire-dashboard|product-version": "13.1.0-preview.1.25568.1",
    "aspire-dashboard|fixed-tag": "13.1.0-preview.1.25568.1",
    "aspire-dashboard|minor-tag": "13.1",

After this change:

    "aspire-dashboard|build-version": "13.1.0-preview.1.25568.1",
    "aspire-dashboard|product-version": "13.1.0",
    "aspire-dashboard|fixed-tag": "13.1.0",
    "aspire-dashboard|minor-tag": "13.1",

@lbussell lbussell requested review from a team and joperezr as code owners November 18, 2025 16:14
@lbussell lbussell enabled auto-merge (squash) November 18, 2025 16:14
@lbussell lbussell mentioned this pull request Nov 18, 2025
Merged
@lbussell lbussell merged commit 02b04f9 into dotnet:nightly Nov 19, 2025
7 checks passed
@lbussell lbussell deleted the fix-aspire-product-ver branch November 19, 2025 14:47
@lbussell lbussell added the needs-backport PR that should be backported to another branch label Dec 3, 2025
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Dec 3, 2025
@lbussell
Fix Aspire Dashboard product version resolution in update-dependencies (
d818870 
dotnet#6831)
@lbussell lbussell mentioned this pull request Dec 3, 2025
Merged
lbussell added a commit that referenced this pull request Dec 4, 2025
@lbussell
Fix Aspire Dashboard product version resolution in update-dependencies (
859a87f 
#6831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mthalman mthalman mthalman approved these changes

@joperezr joperezr Awaiting requested review from joperezr joperezr is a code owner

Assignees

No one assigned

Labels

needs-backport PR that should be backported to another branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lbussell @mthalman