Prevent trimmer unreachable body optimization for AOT #23827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run xamarin-macios-pr |
|
No pipelines are associated with this pull request. |
Member
|
@sbomer do you still want this? it looks like there's another fix on the way: dotnet/runtime#119820 |
Member
Author
|
Nope, closing in favor of dotnet/runtime#119820. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent this optimization from running when we are planning to AOT the trimmed output.
This optimization can cause problems when it rewrites compiler-generated property accessors that NativeAOT expects to see (to map annotations to the underlying field).
Fixes dotnet/runtime#119780.