Skip to content

Prevent trimmer unreachable body optimization for AOT #23827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbomer wants to merge 2 commits into from
Closed

Prevent trimmer unreachable body optimization for AOT #23827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8072d6
Prevent trimmer unreachable body optimization for AOT
sbomer Sep 16, 2025
e0d080b
Merge remote-tracking branch 'origin/main' into fixPropertyWarning
rolfbjarne Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@
<_AggressiveAttributeTrimming Condition="'$(_UseNativeAot)' == 'true'">false</_AggressiveAttributeTrimming>
<_AggressiveAttributeTrimming Condition="'$(_AggressiveAttributeTrimming)' == ''">true</_AggressiveAttributeTrimming>

<!--
With NativeAOT we want to prevent ILLink from rewriting unreachable bodies so that the NativeAOT toolchain can do its own analysis on the original
method bodies. This ensures that NativeAOT can find backing fields for compiler-generated properties.
-->
<_TrimmerUnreachableBodies Condition="'$(_UseNativeAot)' == 'true'">false</_TrimmerUnreachableBodies>

<!-- This property is also defined in Xamarin.Shared.props, but that file is imported too late for us to use the definition, and we can't remove it from Xamarin.Shared.props quite yet, because that would break legacy
(in other words: once we drop support for legacy Xamarin, we can remove the other definition) -->
<_CanOutputAppBundle Condition="'$(_CanOutputAppBundle)' == '' And ('$(OutputType)' == 'Exe' Or '$(IsAppExtension)' == 'true')">true</_CanOutputAppBundle>
Expand Down
Loading