[msbuild] Pass the XamarinTask instance along when calling CompressionHelper.TryCompress. #24439

rolfbjarne · 2025-12-12T18:21:37Z

Pass the XamarinTask instance along when calling
CompressionHelper.TryCompress, so that TryCompress can use the instance
ExecuteAsync method on XamarinTask.

This is required for a future change, where the instance
XamarinTask.ExecuteAsync method will set the environment to use the
current/correct version of Xcode.

…nHelper.TryCompress. Pass the XamarinTask instance along when calling CompressionHelper.TryCompress, so that TryCompress can use the instance ExecuteAsync method on XamarinTask. This is required for a future change, where the instance XamarinTask.ExecuteAsync method will set the environment to use the current/correct version of Xcode.

Copilot

Pull request overview

This PR refactors the compression/decompression helper methods to accept a XamarinTask instance instead of just a TaskLoggingHelper, enabling future changes where the task's ExecuteAsync method will set the correct Xcode environment. The refactoring is systematic and consistent across all affected files.

Key Changes:

Modified CompressionHelper.TryCompress and CompressionHelper.TryDecompress to accept XamarinTask task parameter instead of TaskLoggingHelper log
Updated XamarinTask.ExecuteAsync to include an optional CancellationToken parameter
Updated all call sites across multiple task classes to pass the task instance (this)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
msbuild/Xamarin.MacDev.Tasks/Tasks/XamarinTask.cs	Added `CancellationToken?` parameter to the instance `ExecuteAsync` method to support cancellation in compression operations
msbuild/Xamarin.MacDev.Tasks/Decompress.cs	Updated `TryCompress` and `TryDecompress` methods to accept `XamarinTask` instead of `TaskLoggingHelper`, allowing access to the task's `ExecuteAsync` method; updated internal helper methods accordingly
msbuild/Xamarin.MacDev.Tasks/Tasks/Zip.cs	Updated call to `CompressionHelper.TryCompress` to pass `this` instead of `Log`
msbuild/Xamarin.MacDev.Tasks/Tasks/Unzip.cs	Updated call to `CompressionHelper.TryDecompress` to pass `this` instead of `Log`
msbuild/Xamarin.MacDev.Tasks/Tasks/ResolveNativeReferences.cs	Updated multiple calls to `CompressionHelper.TryDecompress` and `TryResolveXCFramework` to pass `this` instead of `Log`; updated `TryResolveXCFramework` signature to accept `XamarinTask`
msbuild/Xamarin.MacDev.Tasks/Tasks/CreateBindingResourcePackage.cs	Updated call to `CompressionHelper.TryCompress` to pass `this` instead of `Log`

msbuild/Xamarin.MacDev.Tasks/Decompress.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2025-12-15T09:02:03Z

✅ [CI Build #0b53660] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T09:04:57Z

✅ [PR Build #0b53660] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T09:31:25Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:01:25Z

✅ [CI Build #0b53660] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:09:28Z

💻 [CI Build #0b53660] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:14:09Z

💻 [CI Build #0b53660] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:15:54Z

💻 [CI Build #0b53660] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:25:40Z

💻 [CI Build #0b53660] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:49:16Z

💻 [CI Build #0b53660] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T12:47:10Z

🚀 [CI Build #0b53660] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 120 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0b536607e842b2df2304ad0ca50816e8679932c4 [PR build]

rolfbjarne requested review from emaf and mauroa as code owners December 12, 2025 18:21

rolfbjarne requested a review from Copilot December 12, 2025 18:21

Copilot started reviewing on behalf of rolfbjarne December 12, 2025 18:22 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

msbuild/Xamarin.MacDev.Tasks/Decompress.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Dec 13, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Update msbuild/Xamarin.MacDev.Tasks/Decompress.cs

0b53660

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

mauroa approved these changes Dec 15, 2025

View reviewed changes

emaf approved these changes Dec 15, 2025

View reviewed changes

rolfbjarne merged commit 6ff086f into main Dec 15, 2025
45 checks passed

[msbuild] Pass the XamarinTask instance along when calling CompressionHelper.TryCompress. #24439

[msbuild] Pass the XamarinTask instance along when calling CompressionHelper.TryCompress. #24439

Uh oh!

Conversation

rolfbjarne commented Dec 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes:

Reviewed changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ [CI Build #0b53660] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ [PR Build #0b53660] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ [CI Build #0b53660] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #0b53660] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #0b53660] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #0b53660] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #0b53660] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #0b53660] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 15, 2025

🚀 [CI Build #0b53660] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants