Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR replaces the deprecated iOS OpenUrl call with the new overload that supports iOS 12.2 and later.
- Replaces the deprecated OpenUrl usage with the new overload including options and a null completion handler.
- Removes the now redundant warning suppression pragmas.
Reviewed Changes
| File | Description |
|---|---|
| src/BlazorWebView/src/Maui/iOS/IOSWebViewManager.cs | Updated the OpenUrl call to use the modern overload compliant with iOS 12.2+ |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
This was referenced Mar 4, 2025
mattleibow
previously requested changes
Mar 4, 2025
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
Member
Author
|
|
rmarinho
approved these changes
Mar 6, 2025
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
rmarinho
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Replace deprecated iOS OpenUrl * Add failure logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The previously used
OpenUrlcall was deprecated back in iOS 10. The new call, in the .NET bindings an overload, is already also supported since iOS 10: https://developer.apple.com/documentation/uikit/uiapplication/open(_:options:completionhandler:)Since we support iOS 12.2 and up we can safely just replace the whole call without checking for iOS versions.
Issues Fixed
Fixes #25602