Skip to content

Replace deprecated iOS OpenUrl #28160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 2 commits into from
Mar 10, 2025
Merged

Replace deprecated iOS OpenUrl #28160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d7e40
Replace deprecated iOS OpenUrl
jfversluis Mar 4, 2025
4e104ac
Add failure logging
jfversluis Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/BlazorWebView/src/Maui/iOS/IOSWebViewManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ public WebViewUIDelegate(BlazorWebViewHandler webView)
_webView = webView ?? throw new ArgumentNullException(nameof(webView));
}


public override void RunJavaScriptAlertPanel(WKWebView webView, string message, WKFrameInfo frame, Action completionHandler)
{
PresentAlertController(
Expand Down Expand Up @@ -246,9 +245,13 @@ public override void DecidePolicy(WKWebView webView, WKNavigationAction navigati
{
_webView.Logger.LaunchExternalBrowser(uri);

#pragma warning disable CA1416, CA1422 // TODO: OpenUrl(...) has [UnsupportedOSPlatform("ios10.0")]
UIApplication.SharedApplication.OpenUrl(requestUrl);
#pragma warning restore CA1416, CA1422
UIApplication.SharedApplication.OpenUrl(requestUrl, new UIApplicationOpenUrlOptions(), (success) =>
{
if (!success)
{
_webView.Logger.LogError($"There was an error trying to open URL: {requestUrl}");
}
});
}

if (strategy != UrlLoadingStrategy.OpenInWebView)
Expand Down
Loading