Skip to content

Revert "[Accessibility] Add 'button' for TalkBalk on Android Tap Gesture Recognizers"#28868

Merged
rmarinho merged 1 commit intomainfrom
revert-28393-dev/TJ/BindableLayoutAccessibility-Android
Apr 9, 2025
Merged

Revert "[Accessibility] Add 'button' for TalkBalk on Android Tap Gesture Recognizers"#28868
rmarinho merged 1 commit intomainfrom
revert-28393-dev/TJ/BindableLayoutAccessibility-Android

Conversation

@PureWeen
Copy link
Copy Markdown
Member

@PureWeen PureWeen commented Apr 8, 2025

Description

We still need to review this implementation and the implications.

Reverts #28393

Copilot AI review requested due to automatic review settings April 8, 2025 19:55
@PureWeen PureWeen requested a review from a team as a code owner April 8, 2025 19:55
@PureWeen PureWeen requested review from rmarinho and tj-devel709 April 8, 2025 19:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/Controls/src/Core/Platform/SemanticExtensions.cs:8

  • Ensure that the removal of the TapGestureRecognizerNeedsButtonAnnouncement method is properly reflected in your automated tests (TestCases.HostApp and TestCases.Shared.Tests) to verify expected accessibility behavior.
internal static bool TapGestureRecognizerNeedsButtonAnnouncement(this View virtualView)

src/Controls/src/Core/Platform/Android/Extensions/SemanticExtensions.cs:14

  • Confirm that the updated condition using TapGestureRecognizerNeedsDelegate correctly covers all accessibility scenarios previously handled by separate checks, and ensure relevant tests are updated accordingly.
if (virtualView.TapGestureRecognizerNeedsDelegate())

@PureWeen PureWeen added this to the .NET 9 SR6 milestone Apr 8, 2025
@PureWeen PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Apr 8, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Apr 8, 2025
@jsuarezruiz jsuarezruiz added the t/a11y Relates to accessibility label Apr 9, 2025
@rmarinho rmarinho added the area-gestures Gesture types label Apr 9, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Apr 9, 2025
@rmarinho rmarinho merged commit 7b9d351 into main Apr 9, 2025
124 of 128 checks passed
@rmarinho rmarinho deleted the revert-28393-dev/TJ/BindableLayoutAccessibility-Android branch April 9, 2025 11:31
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Apr 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-gestures Gesture types p/0 Current heighest priority issues that we are targeting for a release. t/a11y Relates to accessibility

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants