Skip to content

Revert "[Accessibility] Add 'button' for TalkBalk on Android Tap Gesture Recognizers" #28868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 1 commit into from
Apr 9, 2025
Merged

Revert "[Accessibility] Add 'button' for TalkBalk on Android Tap Gesture Recognizers" #28868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/Controls/src/Core/Platform/Android/Extensions/SemanticExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,8 @@ public static void UpdateSemanticNodeInfo(this View virtualView, AccessibilityNo
if (info == null)
return;

if (virtualView.TapGestureRecognizerNeedsActionClick())
{
// Add "double tap to activate" to the screen reader
if (virtualView.TapGestureRecognizerNeedsDelegate())
info.AddAction(AccessibilityNodeInfoCompat.AccessibilityActionCompat.ActionClick);
}
if (virtualView.TapGestureRecognizerNeedsButtonAnnouncement())
{
// Add "button" to the screen reader
info.ClassName = "android.widget.Button";
}
}

internal static void AddOrRemoveControlsAccessibilityDelegate(this View virtualView)
Expand Down
15 changes: 0 additions & 15 deletions src/Controls/src/Core/Platform/SemanticExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ internal static bool ControlsAccessibilityDelegateNeeded(this View virtualView)
=> virtualView.TapGestureRecognizerNeedsDelegate();

internal static bool TapGestureRecognizerNeedsDelegate(this View virtualView)
=> virtualView.TapGestureRecognizerNeedsButtonAnnouncement();

internal static bool TapGestureRecognizerNeedsActionClick(this View virtualView)
{
foreach (var gesture in virtualView.GestureRecognizers)
{
Expand All @@ -20,17 +17,5 @@ internal static bool TapGestureRecognizerNeedsActionClick(this View virtualView)
}
return false;
}

internal static bool TapGestureRecognizerNeedsButtonAnnouncement(this View virtualView)
{
foreach (var gesture in virtualView.GestureRecognizers)
{
if (gesture is TapGestureRecognizer)
{
return true;
}
}
return false;
}
}
}
Loading