[iOS] Fixing #28912 by only hiding context buttons when user already stopped dragging the cell #28914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… item is clicked in ListView context menu. Checking PopoverPresentationController for null, it seems to be null checked already in all other places.
…not be called when overridden in derived class
VitalyKnyazev
changed the title
VitalyKnyazev
changed the title
jsuarezruiz
reviewed
Apr 11, 2025
| @@ -1655,7 +1655,7 @@ void UpdateNavigationBarVisibility(bool animated) | |||
| return; | |||
|
|
|||
| var hasNavBar = NavigationPage.GetHasNavigationBar(current); | |||
| if (!_navigation.TryGetTarget(out NavigationRenderer navigationRenderer)) | |||
| if (_navigation.TryGetTarget(out NavigationRenderer navigationRenderer)) | |||
There was a problem hiding this comment.
While can understand the changes in the ContextScrollViewDelegate class, I think need more context here? why are you changing this condition?
There was a problem hiding this comment.
Yes this change is not related to the main issue, but it is clearly a copy/paste bug and can cause NRE in the next line.
There was a problem hiding this comment.
Happy to roll back this one if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixing #28912 by only hiding context buttons when user already stopped dragging the cell.
Also first commit fixes potential NRE.
Issues Fixed
Fixes #28912